Skip to content

Fix leak in thunar_window_open_files_in_location

correctmost requested to merge correctmost/thunar:cm/fix-open-files-leak into master

Leak report

Direct leak of 86 byte(s) in 2 object(s) allocated from:
    #0 0x6495518be7f9 in malloc (/usr/asan/bin/thunar+0x4987f9)
    #1 0x7834f76dce4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7834f76f4f54 in g_strconcat /usr/src/debug/glib2/build/../glib/glib/gstrfuncs.c:585:12
    #3 0x7834f76b4141 in g_escape_file_uri /usr/src/debug/glib2/build/../glib/glib/gconvert.c:1423:9
    #4 0x7834f76b4141 in g_filename_to_uri /usr/src/debug/glib2/build/../glib/glib/gconvert.c:1762:17
    #5 0x649551cebe00 in thunar_window_open_files_in_location thunar/thunar/thunar-window.c:1252:27
    #6 0x649551977a92 in thunar_action_manager_action_open_location thunar/thunar/thunar-action-manager.c:1473:3
    #7 0x7834f762c699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #8 0x7834f765d2a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #9 0x7834f764da0b in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3520:7
    #10 0x7834f764dc71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #11 0x7834f764dd33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #12 0x7834f87ee073 in gtk_widget_activate gtk/builddir/../gtk/gtkwidget.c:7845:7
    #13 0x7834f85117bf in gtk_menu_shell_activate_item gtk/builddir/../gtk/gtkmenushell.c:1375:3
    #14 0x7834f85148e7 in gtk_menu_shell_button_release gtk/builddir/../gtk/gtkmenushell.c:791:19
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports