Skip to content

Fix leaks when using Open Item Location menu item

correctmost requested to merge correctmost/thunar:cm/open-files-in-location-leak into master

Leak report

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x620187d097b9 in malloc (/usr/local/bin/thunar+0x4987b9)
    #1 0x7afe9b5ffe4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7afe9b5f498b in g_list_prepend /usr/src/debug/glib2/build/../glib/glib/glist.c:253:14
    #3 0x620187dcf1c3 in thunar_application_get_windows thunar/thunar-application.c:1350:24
    #4 0x620188137266 in hash_table_entry_show_and_select_files thunar/thunar-window.c:1185:17
    #5 0x7afe9b5e6f4a in g_hash_table_foreach /usr/src/debug/glib2/build/../glib/glib/ghash.c:2117:10
    #6 0x620188136de2 in thunar_window_open_files_in_location thunar/thunar-window.c:1270:3
    #7 0x620187dc2a52 in thunar_action_manager_action_open_location thunar/thunar-action-manager.c:1473:3
    #8 0x7afe9b54f699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #9 0x7afe9b5802a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #10 0x7afe9b570a0b in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3520:7
    #11 0x7afe9b570c71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #12 0x7afe9b570d33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #13 0x7afe9bebd915 in gtk_widget_activate (/usr/local/lib/libgtk-3.so.0+0x4bd915)
    #14 0x7afe9bce5ca4 in gtk_menu_shell_activate_item (/usr/local/lib/libgtk-3.so.0+0x2e5ca4)
    #15 0x7afe9bce4664 in gtk_menu_shell_button_release gtkmenushell.c
    #16 0x7afe9bcd0c6f in gtk_menu_button_release gtkmenu.c
    #17 0x7afe9ba9438c in _gtk_marshal_BOOLEAN__BOXEDv (/usr/local/lib/libgtk-3.so.0+0x9438c)
    #18 0x7afe9b570b61 in _g_closure_invoke_va /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:897:7
    #19 0x7afe9b570b61 in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3424:8
    #20 0x7afe9b570c71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #21 0x7afe9b570d33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #22 0x7afe9bebd7d4 in gtk_widget_event_internal gtkwidget.c
    #23 0x7afe9bebcb3a in gtk_widget_event (/usr/local/lib/libgtk-3.so.0+0x4bcb3a)
    #24 0x7afe9bcc5e09 in propagate_event_up gtkmain.c
    #25 0x7afe9bcc60ef in propagate_event gtkmain.c
    #26 0x7afe9bcc61d0 in gtk_propagate_event (/usr/local/lib/libgtk-3.so.0+0x2c61d0)
    #27 0x7afe9bcc4d45 in gtk_main_do_event (/usr/local/lib/libgtk-3.so.0+0x2c4d45)
    #28 0x7afe9c6125b4 in _gdk_event_emit (/usr/local/lib/libgdk-3.so.0+0x405b4)

Testing

  • I didn't see any new LSan or ASan errors after applying the patch

Merge request reports