Skip to content

Fix g_object_get leak in thunar_window_init

correctmost requested to merge correctmost/thunar:cm/fix-window-init-leak into master

Leak report

Direct leak of 22 byte(s) in 1 object(s) allocated from:
    #0 0x5e8062bec7d9 in malloc (/usr/local/bin/thunar+0x4987d9)
    #1 0x798e47660e4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x798e4767725a in g_strdup /usr/src/debug/glib2/build/../glib/glib/gstrfuncs.c:323:17
    #3 0x798e475d73ac in g_strdup_inline /usr/src/debug/glib2/build/../glib/glib/gstrfuncs.h:321:10
    #4 0x798e475d73ac in value_lcopy_string /usr/src/debug/glib2/build/../glib/gobject/gvaluetypes.c:315:17
    #5 0x798e475c5ce9 in g_object_get_valist /usr/src/debug/glib2/build/../glib/gobject/gobject.c:3271:7
    #6 0x798e475c5ce9 in g_object_get_valist /usr/src/debug/glib2/build/../glib/gobject/gobject.c:3241:1
    #7 0x798e475c613c in g_object_get /usr/src/debug/glib2/build/../glib/gobject/gobject.c:3366:3
    #8 0x5e8063030797 in thunar_window_init thunar/thunar/thunar-window.c:825:3
    #9 0x798e475dd848 in g_type_create_instance /usr/src/debug/glib2/build/../glib/gobject/gtype.c:1951:5
    #10 0x798e475c2684 in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2606:24
    #11 0x798e475c497a in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2923:29
    #12 0x798e475c497a in g_object_new_valist /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2945:16
    #13 0x798e475c4d2f in g_object_new /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2418:12
    #14 0x5e8062cb37b4 in thunar_application_open_window thunar/thunar/thunar-application.c:1478:12
    #15 0x5e8062ccca0d in thunar_application_process_files_finish thunar/thunar/thunar-application.c:1693:11
    #16 0x5e8062ccf3c0 in thunar_browser_poke_file_internal thunar/thunar/thunar-browser.c:498:9
    #17 0x5e8062cce67b in thunar_browser_poke_file thunar/thunar/thunar-browser.c:537:3
    #18 0x5e8062cb6d5a in thunar_application_process_files thunar/thunar/thunar-application.c:1765:3
    #19 0x5e8062cb67af in thunar_application_process_filenames thunar/thunar/thunar-application.c:1871:7
    #20 0x5e8062cc714f in thunar_application_command_line thunar/thunar/thunar-application.c:550:8
    #21 0x798e477bd373 in _g_cclosure_marshal_INT__OBJECTv /usr/src/debug/glib2/build/../glib/gio/gmarshal-internal.c:847:14
    #22 0x798e475d1b61 in _g_closure_invoke_va /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:897:7
    #23 0x798e475d1b61 in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3424:8
    #24 0x798e475d1c71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #25 0x798e475d1d33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #26 0x798e47826e9f in g_application_call_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1103:7
    #27 0x798e47826e9f in g_application_call_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1080:1
    #28 0x798e4782af29 in g_application_real_local_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1179:7
    #29 0x798e4782b0a6 in g_application_run /usr/src/debug/glib2/build/../glib/gio/gapplication.c:2681:8
    #30 0x5e8062c736e3 in main thunar/thunar/main.c:86:3
    #31 0x798e47393e07 in __libc_start_call_main /usr/src/debug/glibc/glibc/csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #32 0x798e47393ecb in __libc_start_main /usr/src/debug/glibc/glibc/csu/../csu/libc-start.c:360:3

Testing

  • I didn't see any new LSan or ASan errors after applying the patch

Merge request reports