Skip to content

Fix leaks in thunar_application_command_line

correctmost requested to merge correctmost/thunar:cm/app-cli-leak into master

Leak report

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x59d00ebe8aa9 in malloc (/usr/local/bin/thunar+0x457aa9) (BuildId: 7527e34e3d860c35)
    #1 0x7e0d32adce4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7e0d32ad198b in g_list_prepend /usr/src/debug/glib2/build/../glib/glib/glist.c:253:14
    #3 0x59d00ec7e52b in thunar_application_get_windows thunar/thunar/thunar-application.c:1349:24
    #4 0x59d00ec8abb9 in thunar_application_command_line thunar/thunar/thunar-application.c:559:17
    #5 0x7e0d32c39373 in _g_cclosure_marshal_INT__OBJECTv /usr/src/debug/glib2/build/../glib/gio/gmarshal-internal.c:847:14
    #6 0x7e0d32a4db61 in _g_closure_invoke_va /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:897:7
    #7 0x7e0d32a4db61 in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3424:8
    #8 0x7e0d32a4dc71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #9 0x7e0d32a4dd33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #10 0x7e0d32ca2e9f in g_application_call_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1103:7
    #11 0x7e0d32ca2e9f in g_application_call_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1080:1
    #12 0x7e0d32ca6f29 in g_application_real_local_command_line /usr/src/debug/glib2/build/../glib/gio/gapplication.c:1179:7
    #13 0x7e0d32ca70a6 in g_application_run /usr/src/debug/glib2/build/../glib/gio/gapplication.c:2681:8
    #14 0x59d00ec58c37 in main thunar/thunar/main.c:86:3
    #15 0x7e0d3280fe07 in __libc_start_call_main /usr/src/debug/glibc/glibc/csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #16 0x7e0d3280fecb in __libc_start_main /usr/src/debug/glibc/glibc/csu/../csu/libc-start.c:360:3
    #17 0x59d00eafc9c4 in _start (/usr/local/bin/thunar+0x36b9c4) (BuildId: 7527e34e3d860c35)

Testing

  • I didn't see any new LSan or ASan errors after applying the patch

Merge request reports