Skip to content
Snippets Groups Projects

Use libxfce4ui API to create dialog when renaming launchers

Merged Manuel Grießmayr requested to merge (removed):refactor_dialog into master

Hi @alexxcons
Here's a little xmas patch for you :smile:
So what does this patch do? It uses the libxfce4ui API to create the dialog when renaming launchers instead of manually creating a gtk dialog to save some lines of code.
Only downside I see with this patch is a deprecation warning when using GTK_STOCK_DIALOG_QUESTION but we can suppress it with "gtk-dialog-question" if you like. Looks like we have to use it due to the design of the libxfce4ui API.
What do you think?

Merge request reports

Merge request pipeline #25884 passed

Merge request pipeline passed for fe2a5bd7

Merged by Alexander SchwinnAlexander Schwinn 1 year ago (Dec 22, 2023 9:22am UTC)

Loading

Pipeline #25885 passed

Pipeline passed for 8655194c on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading