Use libxfce4ui API to create dialog when renaming launchers (!425) · Merge requests · Xfce / thunar

Manuel Grießmayr requested to merge dc_coder_84/thunar:refactor_dialog into master Dec 21, 2023

Hi @alexxcons
Here's a little xmas patch for you 😄
So what does this patch do? It uses the libxfce4ui API to create the dialog when renaming launchers instead of manually creating a gtk dialog to save some lines of code.
Only downside I see with this patch is a deprecation warning when using GTK_STOCK_DIALOG_QUESTION but we can suppress it with "gtk-dialog-question" if you like. Looks like we have to use it due to the design of the libxfce4ui API.
What do you think?

Use libxfce4ui API to create dialog when renaming launchers

Merge request reports