Skip to content
Snippets Groups Projects

Limit size of undo/redo history (issue #819)

Merged Limit size of undo/redo history (issue #819)
alexxcons/thunar:limit_undo_redo_history_size into master
1 unresolved thread
Merged Alexander Schwinn requested to merge alexxcons/thunar:limit_undo_redo_history_size into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Schwinn added 1 commit

    added 1 commit

    Compare with previous version

  • Alexander Schwinn resolved all threads

    resolved all threads

  • Alexander Schwinn enabled an automatic merge when the pipeline for d0970f74 succeeds

    enabled an automatic merge when the pipeline for d0970f74 succeeds

  • Alexander Schwinn mentioned in commit 87e3c780

    mentioned in commit 87e3c780

  • Alexander Schwinn merged

    merged

  • Pratyaksh Gautam mentioned in issue #819 (closed)

    mentioned in issue #819 (closed)

  • Pratyaksh Gautam
    Pratyaksh Gautam @hi-im-buggy started a thread on the diff
    • thunar/thunar-job-operation.c
    81 83 static void
    82 84 thunar_job_operation_class_init (ThunarJobOperationClass *klass)
    83 85 {
    84 GObjectClass *gobject_class;
    86 GObjectClass *gobject_class;
    87 ThunarPreferences *preferences;
    85 88
    86 89 gobject_class = G_OBJECT_CLASS (klass);
    87 90 gobject_class->dispose = thunar_job_operation_dispose;
    88 91 gobject_class->finalize = thunar_job_operation_finalize;
    92
    93 preferences = thunar_preferences_get ();
    • Pratyaksh Gautam
      Pratyaksh Gautam @hi-im-buggy ·
      Guest

      Only just realised: shouldn't we also have some callback connected to the signal that this property was changed, reflecting the change in job_operation_list_max_size? Otherwise if the user changes the max history size, they have to restart Thunar for the changed to be reflected.

      Edited by Pratyaksh Gautam
    • Alexander Schwinn
      Alexander Schwinn @alexxcons ·
      Author Maintainer

      Yea, might make sene (Meh, yet another edge-case). I suppose it whould be fine to whipe the history in that case to keep it simple.

    • Pratyaksh Gautam
      Pratyaksh Gautam @hi-im-buggy ·
      Guest

      I guess it can be left behind till someone explicitly asks for it :smile:. Having to restart Thunar to reflect the change is not too bad.

    • Please register or sign in to reply
    Please register or sign in to reply