Make it possible to switch from search entry to other UI elements (Issue #792)
1 unresolved thread
1 unresolved thread
Merge request reports
Activity
One more reason to use GtkStack as proposed in #788
478 478 ThunarPathEntry *path_entry = THUNAR_PATH_ENTRY (widget); 479 479 480 480 /* check if we have a tab key press here and control is not pressed */ 481 if (G_UNLIKELY (event->keyval == GDK_KEY_Tab && (event->state & GDK_CONTROL_MASK) == 0)) 481 if (G_UNLIKELY (event->keyval == GDK_KEY_Tab && (event->state & GDK_CONTROL_MASK) == 0) && path_entry->search_mode == FALSE) Interesting ... I have to say, I have no idea why that addition fixes that problem :D .. though I can confirm that it is possible switch focus via tab key with the patch.
I thought we actually are supposed to be in search_mode == TRUE for the use-case we fix
Maybe it would be nice to have a comment here to tell what is going on
Edited by Alexander SchwinnDoes that really need a comment? I will reimplement it either way.
Edited by Sergios - Anestis Kefalidis
added 72 commits
-
739f478f...6ddce67d - 71 commits from branch
xfce:master
- 8ee04637 - Make it possible to switch from search entry to other UI elements (Issue #792 (closed))
-
739f478f...6ddce67d - 71 commits from branch
enabled an automatic merge when the pipeline for 8ee04637 succeeds
mentioned in commit a90e946a
Please register or sign in to reply