Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • thunar thunar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 336
    • Issues 336
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • thunarthunar
  • Merge requests
  • !117

thunar_file_is_executable () should check if .desktop file is safe

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Yongha Hwang requested to merge MShrimp4/thunar:thunar_file_is_executable into master Jun 05, 2021
  • Overview 5
  • Commits 2
  • Pipelines 3
  • Changes 1

Current implementation of thunar_file_is_executable() does not check if .desktop file entry is safe even if thunar_file_is_desktop_file() provides such feature. The other executables, including binaries, are considered as "not executable" if an executable bit is disabled. This is an inconsistent behavior and may cause security problems.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: thunar_file_is_executable