Toggling Split View may lead to loss of all open tabs

Thunar 4.18.0 on Arch Linux

Steps to reproduce:

1. Press Ctrl+t several times to open multiple tabs
2. Optionally navigate to different locations in each tab
3. Press F3 to enable Split View
4. Press F3 again to disable Split View – end up with only a single tab displaying the last location
5. Close and re-open the window (with Preferences > Behavior > Restore tabs on startup = on) to get all original tabs back

This could be prevented if after step 3 focus is set to the pane with all existing tabs.

Thank you for reporting !

I can reproduce the problem on current master, and will have a look at in the next days

added 5. Split View 5. Tabs labels

changed milestone to %4.18.2

This could be prevented if after step 3 focus is set to the pane with all existing tabs.

Hmm, not that simple, since it is possible to have tabs on both split view panes.

Actually, the current behavior (dropping all tabs of the non-focused pane) seems to as well be used in Caja and Nemo. Though sure, restoring them on restart is rather strange

Edit: Ah, sorry, I was wrong .. just ignore waht I said

Maybe...

986.patch

diff --git a/thunar/thunar-window.c b/thunar/thunar-window.c
index e01770f3..bbbc06ab 100644
--- a/thunar/thunar-window.c
+++ b/thunar/thunar-window.c
@@ -2319,9 +2319,8 @@ thunar_window_notebook_page_removed (GtkWidget    *notebook,
     {
       if (thunar_window_split_view_is_active (window))
         {
-          /* select the other notebook if the current gets closed */
-          if (notebook == window->notebook_selected)
-            thunar_window_paned_notebooks_switch (window);
+          if (notebook != window->notebook_selected)
+            window->notebook_selected = notebook;
 
           thunar_window_action_toggle_split_view (window);
         }
@@ -3607,6 +3606,8 @@ thunar_window_action_toggle_split_view (ThunarWindow *window)
 
   if (thunar_window_split_view_is_active (window))
     {
+      thunar_window_paned_notebooks_switch (window);
+
       if (window->notebook_selected == window->notebook_left)
         {
           /** without split view, no VISUAL selection indicator needed:
@@ -3614,15 +3615,19 @@ thunar_window_action_toggle_split_view (ThunarWindow *window)
            *  the remaining notebook.
            **/
           thunar_window_paned_notebooks_indicate_focus (window, window->notebook_right);
+          g_signal_handlers_disconnect_by_func(G_OBJECT (window->notebook_right), G_CALLBACK (thunar_window_notebook_page_removed), window);
           gtk_widget_destroy (window->notebook_right);
           window->notebook_right = NULL;
         }
       else if (window->notebook_selected == window->notebook_right)
         {
           thunar_window_paned_notebooks_indicate_focus (window, window->notebook_left);
+          g_signal_handlers_disconnect_by_func(G_OBJECT (window->notebook_left), G_CALLBACK (thunar_window_notebook_page_removed), window);
           gtk_widget_destroy (window->notebook_left);
           window->notebook_left = NULL;
         }
+
+      thunar_window_notebook_show_tabs (window);
     }
   else
     {

It's just an idea.

Thanks for the patch, though I find it rather confusing … I suppose the right thing to do is, to just focus the left notebook on F3(open splitview) instead of the right one. I can as well take a look later on.

My preferred behavior:

1. Initial pane retains focus.
2. If either side pane contains more than one tab, when Split View is turned off, display a warning dialog similar to the already existing "Close window with multiple tabs" including the checkmark not to ask again.

The first patch keeps the focus on the current notebook instead of switching, in order to fix the initial issue .. a rather simple patch (fine to be backported to 4.18 branch)

The second patch re-uses the xfce_dialog_confirm_close_tabs dialog to ask when f3 is pressed while the other notebook has more than one tab open ... that dialog is not a perfect fit .. specially, the option 'close tab' is rather confusing. So I suppose we should not reuse that dialog, but need a new dialog for it without that option. Though the general logic should already be fine.

Here the patches:

0001-SplitView-keep-focus-on-old-notebook-Issue-986.patch

0002-Split-View-Ask-before-closing-tabs-Issue-986.patch

Testing would be very welcome !

With just patch 0001... seems to crash:

1. Press Ctrl+T.
2. Press F3.
3. Close the tab of the newly created notebook by clicking X.

With patch 0001 and 0002... works great!

Edit: BTW, happy new year!!!

Thanks a lot for testing @Technomancer !

I can reproduce the crash of the first patch ... moved parts of the second patch to the first one, to prevent the problem ... applied to master and 4.18 branch.

The dialog will need some more love before it can be applied.

As well for you, a happy new year ! :D

mentioned in commit cf5b1432

mentioned in commit a4776554

mentioned in commit a094d6ce

Added new dialog to master in above commit ... only two buttons, but reusing "misc-confirm-close-multiple-tabs" to skip it on need.

That should be it, closing this issue.

closed

mentioned in issue #1103 (closed)