[RTL] Reversed graphical Back/Forward of mouse gestures

Submitted by Khazar

Assigned to Jannis Pohlmann

Link to original bug (#11398)

Description

Unlike Bug 11383, these are reversed and you may also confirm it by yourselves.

Version: 1.6.3

Cannot reproduce,on thunar master, and 1.8.15.

mouse gestures (click and drag mousewheel) on icon view

added 5. Mouse label

added 5. Icon View label

added 5. Compact View label

Here is a simple patch:

0001-Fix-action-of-Back-Forward-mouse-gesture-when-using-RTL.patch

Gnah, just found out that thunar crashes on gesture-action when "folder-specific settings" are enabled :/ --> #443 (closed)

Patch works fine here (this time no problem to reproduce .. suppose I missed the RTL aspect last time :F !

Though I dont get why you hard-coded GTK_TEXT_DIR_LTR thunar_abstract_icon_view_draw. Seems not to matter. Not sure when this method is called.

The arrows are drawn independent of the text direction, but the associated actions need to be adjusted for RTL.

The arrows are drawn independent of the text direction

Hmm, independent is the wrong word ... just took a try on it, putting in GTK_TEXT_DIR_RTL or GTK_TEXT_DIR_NONE leads to switched arrows.

Lets say GtkTextDirection for the arrow-drawing needs to be fixed in order to as well fix the arrows, no mater if the window is RTL or LTR mode. I added comment to the patch accordingly. Would be ok for you like that ?

0001-Fix-action-of-Back-Forward-mouse-gesture-when-using-.patch

(based on updated thunar master, with the #443 (closed) fix applied)

Alternatively, pass GTK_TEXT_DIR_NONE and change the condition to direction == GTK_TEXT_DIR_LTR || direction == GTK_TEXT_DIR_NONE. Would that work better?

The comment is okay.

Good idea, suppose that will make it more clear !

mentioned in commit 87d919da

Pushed to master, thank you @lastonestanding !

Will be released in 4.16.0

closed