Audio tags rename broken

1. Option and the actual effect does not match up
2. Filename extension is lost if other than "Name only"(This actually works as "Title Tag Only") is used

moved from thunar-plugins/thunar-media-tags-plugin#7 (moved)

@alexxcons I checked out the code and this part is actually included in the Thunar project, not in the plugin. Would you move this issue to Thunar?

Alright, moved

added 5. Bulk Renamer label

Can I work on it if no one else is working on it? It would be my first attempt on the Thunar codebase, so it might take some time.

@MasterChief02 Sure, please go ahead ! If you need help, just let me know !

The plugin itself doesn't differentiate between the suffix and the name. So it just renames the given part. Thus the extension is replaced completely. We can recover the extension by adding it again in the end. But then it is necessary to add that only when either the Audio Tags renamer or some other renamer with similar behavior is used. One of the most straightforward approaches to determining that will be to list all such plugins. But this will need updating Thunar each time a new such renamer is added. The other approach will be to add some functionality in the plugin and thunarx itself so that the plugin itself can tell Thunar about such. Please suggest which one is better?

Good investigation! Though I think it is better to separate extension before handing filename to other plugins and then provide filename (without extension) and the extension itself. It might require clever way not to break backwards compatibility, but I don't think there is a plugin outside Xfce that relies on this feature.

One of the most straightforward approaches to determining that will be to list all such plugins.

This solution might negate the whole purpose of creating a plugin.

Though I think it is better to separate extension before handing filename to other plugins and then provide filename (without extension) and the extension itself.

In that case, I don't think we will be able to define suffix. Because as per the current definition of suffix, it is more like the extension itself.

We can add a checkbox in the bulk renamer dialog box. If the checkbox is checked, then we can explicitly add the extension in the end of new file name. This can allow presentation of extension in case it gets exploited by any renamer or any mode. Can this approach work? Although we can do this automatically also without the need of the checkbox. But I can't say if that will always be a required behavior.

Sorrry, I think I misunderstood the concept: Suffix actually means extension and the behavior is normal yet awkward. I think it just needs to rename its option to "Extension only" and "Name and Extension"

Related MR !199 (merged) opened

closed with commit d66afe5b

added 8. GSoC 2022 label