Offer the possibility to validate copy-operation by comparing checksums

Apologies, I am not sure how to tag this as a feature request.

These are some small improvements I think would greatly enhance Thunar's file transfer capabilities without bloating it.

1. With the 4.16.x releases, I humbly suggest that the word "Queued" would be an improvement over "Frozen" for transfers that are held back until current processes are completed. fixed
2. If a file transfer is cancelled, Thunar should automatically offer to delete incomplete transfers rather than leaving part-files. fixed
3. I was playing around with TeraCopy in Windoze and I really liked how you could tick a check box in the copy or move dialogs and have the process verify the file using md5sum (or another) after the move or copy has completed.

Thanks for reporting !

1. Not sure where frozen is used. Though yes, I agree that we should use "queued". A MR would be very welcome !

2. Sounds good to me, a MR would be welcome!

3. So the idea is to check if the copy 100% matches the original file ? As well ok for me, though I would put such a checkbox only into the preferences, not into the copy dialog. A MR would be welcome !

For the future, please open a single issue for each feature, so they can be discussed separately.

added 2. Feature 5. Dialogs 5. File Operations labels

Hi Alexander,

1. I'm using Manjaro's xfce 4.16 and when I copy or move files from my pc to and external USB hard drive only one transfer is permitted at a time. Any additional concurrent file operations using the same device are "queued" but the transfer dialog labels the jobs as "Frozen by another job on the same device". I think "Queued by another job on the same device" would be better. I've attached an image so developers can see where it appears.

Curiously, I am one of the people affected by the RESUME button not working. Someone else reported the problem I think. I wanted to force a simple jpg file transfer to the same device but clicking Resume causes it to hang requiring me to kill Thunar processes. Once that is working Thunar is going to be awesome!

2. I was playing around with file transfers using Multi Commander in windoze it was very good having the file manager offer to delete any incomplete files on the target drive following a manual cancellation of the transfer.

3. The only disadvantage of having a check box in the preferences rather than the file transfer dialog is that most files that a user copies or movies probably don't need verification. A tiny check box labelled "verify" is unobtrusive but gives access to a useful operation when need. In the preferences Teracopy allows the user to choose from CRC32, MD5, SHA-1, SHA-256, SHA-512, Panama, Tiger, RipeMD, Whirlpool or xxHash.

Hmmm not sure if I have added the attachments correctly. Anyway, just food for though.

"Queued by another job on the same device"

I dont speak english as my native language, though I think it should be "Queued after another job on the same device" or maybe better: "Job queued. Waiting for another job on the same device to finish."

WRT md5 checksum, ok, you are right. Since e.g. a md5 check can consume some time, it should only be done on request. That looks like a bigger chunk of work.

I can just fix 1. Though I will not have time to work on 2. or 3.

Even just "Job queued." would be enough. An explanation of how the file transfer stack works with external devices could be added to the Thunar documentation.

I'll have a look at options 2 and 3 when I get some time. Last time I looked at Thunar's source code it was beyond my abilities to decipher but I would love to be able to contribute tweaks in the future.

mentioned in commit 4666d9af

Ok, sounds good! 1. fixed now for master. As well used "Resuming job ..." over "Unfreezing..."

Excellent. Thanks! You efforts are appreciated!

mentioned in commit a1d2887d

changed the description

Was just about to file a MR for this same issue, so glad you guys already beat me to it, though I was going to suggest 'Paused by another transfer to an active device'.

I see the wording was changed to 'Job queued' and 'Resuming job', but the word 'job' doesn't really mean anything to the average user in the current context of file transfer, unless it used elsewhere. In windows explorer, the file transfer dialog's titlebar mentions '2 Running Actions' when 2 transfer requests are happening at the same time, so using 'Action queued' or 'Resuming action' would make sense to the user.

Related: to 2.): !130 (merged)

mentioned in merge request !138 (merged)

changed the description

As well 2. fixed by !138 (merged) thanks to @MShrimp4 ! To be released in thunar 4.17.5

changed title from Future Feature Request - File Transfer improvements to Offer the possibility to validate copy-operation by comparing checksums

@MShrimp4 : For the "safe copy", your proposal suggests an extra-entry in the file context-menu.

The context menu is already very full. How about adding another enum in the preferences->advanced section instead ? Possibly same values as for *.partial~ (always/only remote/local) ?

Having a checkbox on the pgrogress-dialog is a bit problematic for small files, for which the copy happens faster than you can toggle the box.

mentioned in merge request !144 (merged)

mentioned in commit a1f5df54

3. I was playing around with TeraCopy in Windoze and I really liked how you could tick a check box in the copy or move dialogs and have the process verify the file using md5sum (or another) after the move or copy has completed.

Fixed by !144 (merged) thanks to @MShrimp4 . To be released in thunar 4.17.5