Icon view flicker

The icon view widget occasionally flickers (full redraw from scratch) when performing certain actions.

Examples:

• move hundred empty files from one tab/window to another tab/window
• empty trash containing hundred empty files

Detailed list view is not affected.

Thunar 4.15.3 + exo 4.15.3

added 5. Icon View label

Can as well reproduce with thunar 1.8.15 and exo 4.15.3

Can not reproduce with thunar 1.8.15 and exo xfce-4.14 branch.

added 1. Regression label

Doing git bisect between the two exo versions lead to: exo@6fcefce9

Reverting that commit (by hand) fixes the bug

I reverted that commit -> bug still there. Also, testing with exo 0.12.8 gives the same result.

Uh, I only tested with thunar 1.8.15 this morning. True, for thunar master + revert, the bug is still there. :F So there is more about it.

moved from #439 (moved)

Bug does not occur when navigating to test-folder via sftp://user@localhost/path/to/folder. I suppose it is related to file or folder monitor.

Bad commit: bad4150b

Indeed, reverting it fixes the bug for master. Again looks like you are better at diagnostics than me :)

I suppose we can just revert, since the reason why I moved the spinner out of the menu does not exists any more (no custom menu key-navigation any more, default menu nav. works fine with spinner inside menu)

Minor problem: I dont get the spinner adjusted to the right by using gtk_widget_set_hexpand (item, TRUE); + gtk_widget_set_halign (item, GTK_ALIGN_END) over the deprecated gtk_menu_item_set_right_justified. Any idea would be welcome !

All at all, I am surprised to see that such a flickering can happen, just because of the spinner location :F

Could we not combine the old GtkMenuItem code with the gtk_grid_attach call to align it?

moved from exo#49 (moved)

added 5. Icon View label

Adding a menu is some overhead and I did not get it to work. But "combine it" was the right trigger .. seems like putting the spinner into a box is sufficient as well to prevent the bug:

0001-Wrap-box-around-spinner-to-prevent-flickering-Issue-.patch

Best give it a spin (haha) before I push it !

Works.

What remains is the flickering of individual files (area is invalidated -> grey box for a brief moment). I wonder if we can debug that too.

closed with commit e2df02f8

Ok, pushed. Thanks Theo !

What remains is the flickering of individual files (area is invalidated -> grey box for a brief moment). I wonder if we can debug that too.

That seems to be an older bug .. but yea, please open an issue for it. I wonder if icon-view maybe generally suffers from bad reload performance, and if possibly rate-limiting for folder reload would help on this.