Support XF86Back and Forward keys

Submitted by Mike Massonnet

Assigned to Jannis Pohlmann

Link to original bug (#9378)

Description

Hi,

I know Thunar has already a bunch of shortcut to browse a tree, but it would be nice to add XF86Back and XF86Forward to go back and forth.

Cheers, Mike

Mike Massonnet submitted a patch:

Ok, setting more than >1 shortcuts (accels) to an action just got complicated with GTK+.

Finally looking at the code of our rival (to not name it =)), where it actually works with the default shortcut Alt+Left/Right through a GtkActionGroup (just like it's supposed to be done with GTK+), it furtermore listens to key-press events on the window itself. Should it be done the same? There is really no good way to handle multiple shortcuts for a unique action.

See patch attached, the code has an #ifdef HAVE_X11_XF86KEYSYM_H, and uses the XF86XK_Back/Forward keysyms. If such a key is pressed, it grabs the pointer on the action-group (which is available from the window class), get the action and activate it (if sensitive).

Patch 4664, "0001-Use-multimedia-keys-Back-and-Forward-for-moving-in-t.patch":
0001-Use-multimedia-keys-Back-and-Forward-for-moving-in-t.patch

Mike Massonnet submitted a patch:

Patch 4665, "0001-Use-multimedia-keys-Back-and-Forward-for-moving-in-t.patch":
0001-Use-multimedia-keys-Back-and-Forward-for-moving-in-t.patch

Mike Massonnet submitted a patch:

Patch 4666, "0001-Use-multimedia-keys-Back-and-Forward-bug-9378.patch":
0001-Use-multimedia-keys-Back-and-Forward-bug-9378.patch

Nick Schermer said:

Multimedia keys work fine with menu accelerators. Problem is that a patch like this (hardcoding) can possibly lead to conflicts with daemons like music players, xfsettingsd etc.

b3nmore said:

I'd like to see this feature. It would unify the way (web|file) browsing works. Btw. and just in case it got confused: there are different keysyms for browsers (XF86Back, XF86Forward) and multimedia (XF86AudioPrev, XF86AudioNext).

added 5. Keyboard Shortcuts label

added 2. Feature label

Since GTK version 3.12 the following exists: https://developer.gnome.org/gtk3/stable/GtkApplication.html#gtk-application-set-accels-for-action
However, as far as i understand, accelerators set via this method won't be properly saved when using GtkAccelMap.gtk_accel_map_save()

added Patch label

I came from pcmanfm and expected thunar to work with the Forward/Back keys as pcmanfm did.

I'm not sure what is blocking this from being added, but here's how pcmanfm (which also uses GTK3) did it: https://github.com/lxde/pcmanfm/blob/e6b422b2003126b2116d26cf09f6e6244f1bb41f/src/main-win-ui.c#L260

There is just nobody working on this.

I don't have a keyboard with multimedia keys, cumbersome to mess with xmodmap (and I am busy with other issues) ... though if you can, a merge request would be very welcome! (You might want to check it that 11 year old patch still applies, though I suppose not)

I came from pcmanfm and expected thunar to work with the Forward/Back keys as pcmanfm did.

I was able to add the shortcuts in the Shortcuts tab in Preferences.

Great to hear so!

So if that already works, I suppose this issue can be closed?

mentioned in issue #1340

mentioned in issue #1386 (closed)

mentioned in merge request !485 (merged)

changed milestone to %4.19.3

marked this issue as a duplicate of #1386 (closed)

closed

marked this issue as related to #1386 (closed)

mentioned in issue #1529 (closed)

mentioned in issue #1585 (closed)