SIGSEGV in thunar_launcher_poke when opening or working with the bulk renamer

The following crash occurred when trying to rename files with the bulk renamer. However, I do not know which action exactly caused this; Maybe simply hitting a key or trying to press tab; Because I have attached gdb to it the GUI got frozen and I might not have noticed this immediately. It might already have happened when opening the bulk renamer window.

Thread 1 "thunar" received signal SIGSEGV, Segmentation fault.
0x0000555ba9f79ebe in thunar_launcher_poke (launcher=0x555bac8e9310 [ThunarLauncher],
application_to_use=<optimized out>, folder_open_action=<optimized out>) at thunar-launcher.c:926
926     thunar-launcher.c: Datei oder Verzeichnis nicht gefunden.
(gdb) bt
#0  0x0000555ba9f79ebe in thunar_launcher_poke
    (launcher=0x555bac8e9310 [ThunarLauncher], application_to_use=<optimized out>, folder_open_action=<optimized out>) at thunar-launcher.c:926
#1  0x00007f571c7624e6 in _gtk_marshal_VOID__BOXED_OBJECTv
    (closure=0x555bac729dc0, return_value=<optimized out>, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x555babad7550)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmarshalers.c:3425
#2  0x00007f571be9d206 in _g_closure_invoke_va
    (closure=closure@entry=0x555bac729dc0, return_value=return_value@entry=0x0, instance=instance@entry=0x555babdaef90, args=args@entry=0x7ffdc8ce3f40, n_params=n_params@entry=2, param_types=0x555babad7550)
    at ../glib-2.66.2/gobject/gclosure.c:873
#3  0x00007f571beb5108 in g_signal_emit_valist
    (instance=0x555babdaef90, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffdc8ce3f40) at ../glib-2.66.2/gobject/gsignal.c:3403
#4  0x00007f571beb52f7 in g_signal_emit
    (instance=instance@entry=0x555babdaef90, signal_id=<optimized out>, detail=detail@entry=0)
    at ../glib-2.66.2/gobject/gsignal.c:3550
#5  0x00007f571c6ed980 in gtk_tree_view_row_activated
    (tree_view=tree_view@entry=0x555babdaef90 [GtkTreeView], path=path@entry=0x555babc49a00, column=<optimized out>) at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtktreeview.c:12694
#6  0x00007f571c6ef532 in gtk_tree_view_real_select_cursor_row
    (tree_view=tree_view@entry=0x555babdaef90 [GtkTreeView], start_editing=1)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtktreeview.c:10992
#9  0x00007f571beae454 in <emit signal ??? on instance 0x555babdaef90 [GtkTreeView]>
    (node=<optimized out>, detail=0, instance=0x555babdaef90, emission_return=0x7ffdc8ce42d0, instance_and_params=0x555babe625f0) at ../glib-2.66.2/gobject/gsignal.c:3776
    #7  0x00007f571c760abb in _gtk_marshal_BOOLEAN__BOOLEAN
    (closure=0x555baba93130, return_value=0x7ffdc8ce42d0, n_param_values=<optimized out>, param_values=0x555babe625f0, invocation_hint=<optimized out>, marshal_data=<optimized out>)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmarshalers.c:2185
    #8  0x00007f571be9cfdd in g_closure_invoke
    (closure=closure@entry=0x555baba93130, return_value=return_value@entry=0x7ffdc8ce42d0, n_param_values=2, param_values=param_values@entry=0x555babe625f0, invocation_hint=invocation_hint@entry=0x7ffdc8ce41c0)
    at ../glib-2.66.2/gobject/gclosure.c:810
#10 0x00007f571c4988f6 in gtk_binding_entry_activate
    (entry=0x555babafe4d0, object=object@entry=0x555babdaef90 [GtkTreeView])
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkbindings.c:646
#11 0x00007f571c498d90 in binding_activate
    (binding_set=binding_set@entry=0x555babb799b0, entries=entries@entry=0x555babe8df50 = {...}, object=object@entry=0x555babdaef90 [GtkTreeView], is_release=is_release@entry=0, unbound=unbound@entry=0x7ffdc8ce438c)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkbindings.c:1455
#12 0x00007f571c498f41 in gtk_bindings_activate_list
    (object=object@entry=0x555babdaef90 [GtkTreeView], entries=entries@entry=0x555babe8df50 = {...}, is_release=0) at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkbindings.c:1514
#13 0x00007f571c49a3c2 in gtk_bindings_activate_event
    (object=0x555babdaef90 [GtkTreeView], event=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkbindings.c:1601
#14 0x00007f571c6f4c9a in gtk_tree_view_key_press
    (widget=widget@entry=0x555babdaef90 [GtkTreeView], event=event@entry=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtktreeview.c:6103
#15 0x00007f571c75d829 in _gtk_marshal_BOOLEAN__BOXEDv
    (closure=0x555baba8f9a0, return_value=0x7ffdc8ce45d0, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x555baba8f9d0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmarshalers.c:129
#16 0x00007f571be9d130 in _g_closure_invoke_va
    (closure=closure@entry=0x555baba8f9a0, return_value=return_value@entry=0x7ffdc8ce45d0, instance=instance@entry=0x555babdaef90, args=args@entry=0x7ffdc8ce46a0, n_params=n_params@entry=1, param_types=0x555baba8f9d0)
    at ../glib-2.66.2/gobject/gclosure.c:873
#17 0x00007f571beb445b in g_signal_emit_valist
    (instance=0x555babdaef90, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffdc8ce46a0) at ../glib-2.66.2/gobject/gsignal.c:3403
#18 0x00007f571beb52f7 in g_signal_emit
    (instance=instance@entry=0x555babdaef90, signal_id=<optimized out>, detail=detail@entry=0)
    at ../glib-2.66.2/gobject/gsignal.c:3550
#19 0x00007f571c7085b4 in gtk_widget_event_internal
    (widget=widget@entry=0x555babdaef90 [GtkTreeView], event=event@entry=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkwidget.c:7808
#20 0x00007f571c70a7f2 in gtk_widget_event_internal (event=0x555bac1a83e0, widget=0x555babdaef90 [GtkTreeView])
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkwidget.c:7379
#21 0x00007f571c7293fb in gtk_window_propagate_key_event
    (window=window@entry=0x555babc2ab20 [ThunarRenamerDialog], event=event@entry=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkwindow.c:8223
#22 0x00007f571c72d91b in gtk_window_key_press_event
    (widget=0x555babc2ab20 [ThunarRenamerDialog], event=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkwindow.c:8256
#23 0x00007f571c75d829 in _gtk_marshal_BOOLEAN__BOXEDv
    (closure=0x555baba8f9a0, return_value=0x7ffdc8ce49a0, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x555baba8f9d0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmarshalers.c:129
#24 0x00007f571be9d206 in _g_closure_invoke_va
    (closure=closure@entry=0x555baba8f9a0, return_value=return_value@entry=0x7ffdc8ce49a0, instance=instance@entry=0x555babc2ab20, args=args@entry=0x7ffdc8ce4a70, n_params=n_params@entry=1, param_types=0x555baba8f9d0)
    at ../glib-2.66.2/gobject/gclosure.c:873
#25 0x00007f571beb445b in g_signal_emit_valist
    (instance=0x555babc2ab20, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffdc8ce4a70) at ../glib-2.66.2/gobject/gsignal.c:3403
#26 0x00007f571beb52f7 in g_signal_emit
    (instance=instance@entry=0x555babc2ab20, signal_id=<optimized out>, detail=detail@entry=0)
    at ../glib-2.66.2/gobject/gsignal.c:3550
#27 0x00007f571c7085b4 in gtk_widget_event_internal
    (widget=0x555babc2ab20 [ThunarRenamerDialog], event=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkwidget.c:7808
#28 0x00007f571c5bc8a1 in propagate_event
    (widget=widget@entry=0x555babc2ab20 [ThunarRenamerDialog], event=event@entry=0x555bac1a83e0, captured=captured@entry=0, topmost=topmost@entry=0x0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmain.c:2680
#29 0x00007f571c5bdacf in gtk_propagate_event
    (widget=widget@entry=0x555babc2ab20 [ThunarRenamerDialog], event=event@entry=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmain.c:2724
#30 0x00007f571c5be3d3 in gtk_main_do_event (event=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmain.c:1920
#31 gtk_main_do_event (event=<optimized out>)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gtk/gtkmain.c:1690
#32 0x00007f571c2e69c5 in _gdk_event_emit (event=event@entry=0x555bac1a83e0)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gdk/gdkevents.c:73
#33 0x00007f571c31a272 in gdk_event_source_dispatch
    (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>)
    at /var/tmp/portage/x11-libs/gtk+-3.24.22/work/gtk+-3.24.22/gdk/x11/gdkeventsource.c:367
#34 0x00007f571bdabe6b in g_main_dispatch (context=0x555bab9ed800) at ../glib-2.66.2/glib/gmain.c:3325
#35 g_main_context_dispatch (context=0x555bab9ed800) at ../glib-2.66.2/glib/gmain.c:4016
#36 0x00007f571bdac118 in g_main_context_iterate
    (context=context@entry=0x555bab9ed800, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib-2.66.2/glib/gmain.c:4092
#37 0x00007f571bdac1cf in g_main_context_iteration
    (context=context@entry=0x555bab9ed800, may_block=may_block@entry=1) at ../glib-2.66.2/glib/gmain.c:4157
#38 0x00007f571bfb8ba5 in g_application_run (application=0x555baba030f0 [ThunarApplication], argc=-926003836, 
    argc@entry=2, argv=argv@entry=0x7ffdc8ce4ef8) at ../glib-2.66.2/gio/gapplication.c:2559
#39 0x0000555ba9f47912 in main (argc=2, argv=0x7ffdc8ce4ef8) at main.c:86

Thanks for reporting ! This happened for thunar master/xfce-4.16pre2 ?

Seems like it is not that simple to reproduce.

.. I suppose you started the bulk renamer out of thunar, not via the renamer launcher ?

Do you remember the type/amount of files you tried to rename ?

added 1. Crash / Freeze 3. Need Info 5. Bulk Renamer labels

Yes, certainly that is of the more troublesome kind. I launched the renamer by selecting the files and pressing the key in thunar in the standard view. I did not get to renaming any files because of the crash, but it would have been only 3 files, so that shouldn't be the issue.

I have experienced quite a few thunar crashes recently, making its usage very unreliable. For a start, I am trying to get any clues to why they are happening.

This crash can be easily reproduced by activating a selected row/file.

The cause is most likely the broken context menu. It should look like this:

added 1. Regression label

The context menu only shows add files and remove file. I cannot reproduce the crash easily by activating a selected row/file, however I managed to reproduce it once by clicking on a row, then hitting S-F10 to show the menu.

On activation I as well can reproduce now .. and yes, many items missing in the menu .. should have noticed that :F

I remember that it worked fine in some older dev versions after I introduced thunar-menu .. suppose I broke it during one of the launcher modifications in between :/ Glad you found it before 4.16 release !

Looks like I just missed to initialize "current-folder" for the launcher. This patch fixes the problem for me: 0001-Fix-broken-bulk-renamer-context-menu-Issue-436.patch

I'll check if I as well can add some guard to the launcher, so that uninitialized "current-directory" does not lead to crashes.

Works!

Thanks, I will try this. Slightly off-topic: Wasn't there a way in previous versions to force the bulk-renamer instead of the single file rename dialog? Like pressing Shift-F2 or something? That was quite convenient when mass-renaming files and then a single file with the same scheme that might have been missed, or for similar use cases.

Just tried with thunar 1.6 and 1.8 .. could not find a something+F2 combo which forces the bulk renamer.

I suppose it is ok to open it via "right click-->open with" in that rare case. Though if you think it is needed .... I would merge a patch :)

mentioned in commit f98d415a

Not related, but I found some code duplication:
https://gitlab.xfce.org/xfce/thunar/-/blob/master/thunar/thunar-renamer-dialog.c#L887

About 10 lines later it appears again.

Yes, good spot! Seems like that even can generate some memory leak .. fixed now in d6d88b24

Hardened thunar_launcher_poke a bit for the "invalid use" case to at least dont crash: f98d415a

closed with commit c6eb98de

Pushed to master now, since patch as well confirmed by @lastonestanding . Thank you for pointing on it !