removable device disappear from devices just after mount
The bug occur on thunar-volman v0.9. with thunar v1.8.15, on ArchLinux (both thunar and thunar-volman are not patched after the PKGBUILD), and Manjaro (ArchLinux derived).
The bug is not present on Ubuntu Bionic (thunar 1.6.15, thunar-volman 0.8.1).
I only have this with external USB HDD (Toshiba 4TB external ATA drive: USB ID 0480:0900 Toshiba America Inc MQ04UBF100), that contain a pre-formatted disk, with reserved microsoft and one NTFS partition. The bug doesn't occur with fix local partitions, with another HDD with serveral ext4 partitions or with a USB card reader. I tried with manjaro install cd image on a SDcard, inserted in a USB card reader, at least with ext4 formats.
Il looks like the bug doesn't occur if other partition was already mounted with thunar (not at boot with /etc/fstab).
How to reproduce the bug:
- Boot on the system
- Connect an USB external hard drive with NTFS partition as main partition of the disk
- Click on a device to mount it, it is mounted and then disappear from devices list.
- close all thunar windows, reopen one, and it is again shown in devices list
Activity
moved from thunar-volman#22 (moved)
after doing: thunar -q; thunar .
When I connect the device in USB port, I see:
thunar-volman: Unsupported USB device type "usb". thunar-volman: Unsupported USB device type "usb-storage". thunar-volman: Unknown block device type "disk".
It is well detected anyway, as I can see it in DEVICES section.
But nothing is wrote, when I mount the device (double-click in Thunar, DEVICES sections, and it disappear.
If I close the window then, I get againt he shell prompt and if I restart thunar, the USB disk appear again in DEVICES section, nothing is displayed.
Could I trace something using GDB to help? And in this case, is there specif thing to trace?
Ok, I believe I understood. I right-clicked then in the menu I choose mounting instead of open, and, it then mounted it and its name didn't disappear in devices section, unmounted it, disconnected it reconnected it, and with open, and this time it still disappear, so you well spotted specific cases :).
Thank you for your help.
I will probably format the HDD in EXT4 soon, it will more convenient, as the person that will use it will only use it on Linux computer actually. Do you need more info or test, before I format it, as I believe it could help other people ? Do you think this bug could be really related on NTFS, so I can reproduce later on usb key/sdcard on USB card reader too ? So I could help on this problem with cards, and change the disk to ext4 sooner. else I will wait a little.
I was not able to reproduce the bug with an USB flash drive and I did not find anything wrong in the source code yet (based on the information we have gathered so far). Maybe the exact partition table and file system configuration is needed.
Was the bug present in previous versions of Thunar's 1.8 branch? Is it reproducible with the live session of Xubuntu 20.04?
Don't know for old version of thunar, the disk is recent, I will try on xubuntu 20.04 liveCD. There are 20.04 and 20.04.01, the 20.04 will probably have older version .1.8.14-0ubuntu1, this could be a good test of a possible regression. A bionic has 1.6.15, don't know if could help further?
https://packages.ubuntu.com/search?suite=default§ion=all&arch=any&keywords=thunar&searchon=names
-
Knowing if it works fine with 1.8.14 would be helpful. That version does not include ac909a86.
Nice, at least, we have some clues. I can compile/patch the sources if needed for some tests.
I don't know GTK+ at all, I will read the doc to try to understand which of the elements are used. Knowing the structure that keep the devices could help me to add some prints for debugging.
https://docs.xfce.org/xfce/thunar/start#debugging_support I will try to recompile it with –enable-debug=full as a first try I don't care if it's slow I only use a little on my own desktop. I just seen --disable-debug is set in the default archlinux package.
compile with --enable-debug-full fail (see below, it looks like this fail is related to my bug).
if I compile with --enable-debug=true. I have only the following messages at the time I connect the device, nothing at mounting time.
$ thunar -q; thunar . thunar-volman: Unsupported USB device type "usb". thunar-volman: Unsupported USB device type "usb-storage". thunar-volman: Unknown block device type "disk".
compiling with --enable-debug=full end with the following messages:
make[2]: Entering directory '/data/pacaur/thunar/src/thunar-1.8.15/thunarx' CC libthunarx_3_la-thunarx-config.lo In file included from /usr/include/bits/libc-header-start.h:33, from /usr/include/limits.h:26, from /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include-fixed/limits.h:195, from /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include-fixed/syslimits.h:7, from /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include-fixed/limits.h:34, from /usr/lib/glib-2.0/include/glibconfig.h:11, from /usr/include/glib-2.0/glib/gtypes.h:32, from /usr/include/glib-2.0/glib/galloca.h:32, from /usr/include/glib-2.0/glib.h:30, from /usr/include/glib-2.0/gobject/gbinding.h:28, from /usr/include/glib-2.0/glib-object.h:22, from ../thunarx/thunarx-config.h:28, from thunarx-config.c:25: /usr/include/features.h:397:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] 397 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O) | ^~~~~~~ cc1: all warnings being treated as errors make[2]: *** [Makefile:918: libthunarx_3_la-thunarx-config.lo] Error 1 make[2]: Leaving directory '/data/pacaur/thunar/src/thunar-1.8.15/thunarx' make[1]: *** [Makefile:809: all-recursive] Error 1 make[1]: Leaving directory '/data/pacaur/thunar/src/thunar-1.8.15' make: *** [Makefile:601: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting...So I added in the PKGBUILD, juste before the
./configureline:export CFLAGS=-O export CPPFLAGS=-O
and now, it fails with (just at a line that have big similarities with my bug: thunar_shortcuts_view_poke_device_mount_finish)
CC thunar-thunar-shortcuts-view.o thunar-shortcuts-view.c: In function 'thunar_shortcuts_view_mount': thunar-shortcuts-view.c:2066:39: error: cast between incompatible function types from 'void (*)(ThunarBrowser *, ThunarDevice *, ThunarFile *, GError *, void *)' {aka 'void (*)(struct _ThunarBrowser *, struct _ThunarDevice *, struct _ThunarFile *, struct _GError *, void *)'} to 'void (*)(ThunarBrowser *, ThunarDevice *, ThunarFile *, GError *, void *, gboolean)' {aka 'void (*)(struct _ThunarBrowser *, struct _ThunarDevice *, struct _ThunarFile *, struct _GError *, void *, int)'} [-Werror=cast-function-type] 2066 | (ThunarBrowserPokeDeviceFunc)thunar_shortcuts_view_poke_device_mount_finish, | ^ cc1: all warnings being treated as errors make[3]: *** [Makefile:2208: thunar-thunar-shortcuts-view.o] Error 1 make[3]: Leaving directory '/data/pacaur/thunar/src/thunar-1.8.15/thunar' make[2]: *** [Makefile:923: all] Error 2 make[2]: Leaving directory '/data/pacaur/thunar/src/thunar-1.8.15/thunar' make[1]: *** [Makefile:809: all-recursive] Error 1 make[1]: Leaving directory '/data/pacaur/thunar/src/thunar-1.8.15' make: *** [Makefile:601: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting...Edited by Popolon
compiling with --enable-debug=full end with the following messages: ...
Not sure what is going on there .. compile with --enable-debug=full works fine here. Though in my experience thunar debug messages do not help that much.
Just in case, here some manual to build thunar: https://wiki.xfce.org/thunar/dev/build_and_run
The missing argument is gboolean cancelled
Not sure what function you are talking about .. so now thunar from source compiles for you ? Can you test with thunar-1.8.14 ?
-
The missing argument is gboolean cancelled
Interesting. I checked the 4.14 branch and noticed that b8684c98 was only applied to master.
