thunar-4.15.0 hangs when closing windows using shortcut keys

When closing a thunar window using the assigned shortcut key, thunar sometimes hangs. This happens with 4.15.0, and 442461b1 seems to partly fix it (though I am not 100% sure it really does).

I can however still reproduce the issue rather easily when running thunar --daemon, opening a few windows and then closing them rapidly using the shortcut key; holding down the shortcut key combination is enough to achieve this. It then spills the console with messages like the following:

(thunar:17804): Gtk-CRITICAL **: 23:48:04.072: gtk_accel_group_activate: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed

Still no luck to reproduce :/

To go further into details: So you quit the current thunar and start a daemon ?:

thunar -q; ./thunar/thunar --daemon

Now that terminal will get stuck. You open a new terminal, and start another thunar ?:

./thunar/thunar

Holding Ctrl+n for some seconds, spawning ~20 windows, than Ctrl+q to close them again .. no Gtk-Critical for me :/

Maybe you do it in a different way ? Is it the daemon terminal, which will produce Gtk-CRITICAL messages, or the other one ?

FYI, I reproduced the problem with 4.15.0, but I can't anymore with latest git master

Even with Thunar from git master (39c20861) I still can reproduce the reported issue, sometimes it segfaults at gtk_accel_groups_activate.

In the video below I open multiple Thunar windows with a global shortcut (ctrl+alt+z) and close them with ctrl+w: crash

That perhaps gives a clue to the origin of the problem:

@alexxcons you close the window with ctrl + q. @andreldm you close the window with ctrl + w, as I do.

Andre Miranda and I can reproduce the issue with ctrl + w. Alex cannot.

I cannot reproduce the issue with ctrl + q, too - and neither with ctrl + shift + w (close all windows).

BTW: Andre Mirandas fine video demonstrates the issue exactly. Sometimes thunar can be seen segfaulting, sometimes it starts spamming gtk_accel messages, and sometimes it closes without exhibiting the bug.

Note that it does not happen only when closing the /last/ window. I still have plenty of thunar windows open when it happens.

The function called is actually https://gitlab.xfce.org/xfce/thunar/-/blob/master/thunar/thunar-window.c#L349, even though it will also close the window when no tabs are open.

Haha, ok, looks like only ctrl+w triggers it, now I as well can reproduce .. I'll look into it !

0001-Thunar-hangs-when-closing-windows-using-shortcut-key.patch

^^ Have to remove the accel_group when I am finished using it :/ The patch fixes the crash/freeze, but is still incomplete, since there is:

(thunar:43237): Gtk-CRITICAL **: 21:56:04.715: _gtk_accel_group_detach: assertion 'g_slist_find (accel_group->priv->acceleratables, object) != NULL' failed

Guess I have to properly unregister all accelerators before removing the accel_group.

Maybe I am missing something, but applying this patch does not resolve the hang for me. However, I did not test with git master, so maybe that is the reason for it.

Guess I have to properly unregister all accelerators before removing the accel_group. Yes, this sounds cumbersome, gtk should provide this functionality when removing accel groups. Unfortunately it seems it does not.

This one fixes the bug for me and as well silences the Gtk-CRITICAL:

0001-Thunar-hangs-when-closing-windows-using-shortcut-key.patch

Found that gtk_accel_group_disconnect (accel_group, NULL); can be used to disconnect everything .. not that obvious, but ok :)

@hjudt : Could you please re-test with that patch ? Take care to quit running thunar daemons with thunar -q first.

Thanks, the new patch fixes the issue for me.

closed via commit f6a6dc37

Pushed to master. Thank you for reporting & testing !

Unfortunately, this bug still haunts me now and again, but I am no longer able to reliably reproduce it, at least not with the steps described above.

Re-opening for further investigation.

Using the steps described in my previous comment I was only able to crash Thunar once (it wasn't easy), coredump attached. It would be helpful if you could confirm your stacktrace is similar.

reopened

Unfortunately, I have tried to open many windows and closing them many ways, but I cannot reproduce it under "normal" workflow conditions. However, it still happens rarely after some time, when I have managed some files with thunar. I have not found a way to reproduce the bug with current git master, but gdb attached it once and the gtk_accel messages have appeared in the stacktrace I got with gdb bt. It also shows the same behaviour described earlier. Tricky and nasty...

added 1. Crash / Freeze 5. Keyboard Shortcuts labels

I have not seen this with the latest thunar versions for quite a while. We might consider this solved; if it happens again, I can reopen it.

closed

This (i.e. a hang or segfault when pressing Ctrl+W) happens to me relatively frequently when having multiple windows open and attempting to close one of them. (Un)fortunately, I can't reliably reproduce it.

I'm attaching a full backtrace from one such crash. Is there anything else I can do to help?

thunar 4.15.3
GTK 3.24.24

Thanks for the bt !

Unfortunately I cannot read any hint from it :[ I suppose we will need a reproducer to fix this one.

.. reopening

reopened

I'm also affected by this again almost on a daily basis and it's not that hard to reproduce, just run thunar --daemon, open several windows (e.g. 20) via a global hotkey and close them all with ctrl+w, repeat the process about 5 times (I'll check if that's reproducible with xfce-test).

I don't get any segfault, Thunar just hangs indefinitely logging critical messages, here are two gdb's backtraces of two consecutive sessions: backtrace1.txt backtrace2.txt

Searching around I found this ten year old bug for gtk/gajim which was closed without a solution.

Yep, even easier to reproduce on xfce-test:devel (super+e is the hotkey to open thunar), but it does crash instead of hanging. crash.gif

@alexxcons I hope this helps, since you worked recently with actions/groups/accelerators perhaps you can have some idea, if not I can try later to disable Thunar's components on the code one by one until have it barebones, hopefully making more obvious what's causing the issue.

One interesting thing I noticed is that I couldn't crash Thunar when using ctrl+q (Close window).

Looking at thunar_window_action_close_tab, I tweaked it to mimic thunar_window_action_close_window when there is only one single tab, seems to work.

Indeed, with 20+ windows I as well can reproduce now, even without --daemon ! Seems like I just did not try hard enough :F

With your fix I was not able to reproduce. If you agree, for me it would be fine to push that fix.

Also fixes #398 (closed).

@alexxcons there you go: !52 (merged). I changed it to avoid an unnecessary check.

mentioned in merge request !52 (merged)

Thanks @andreldm ! Merged now. Will be available in thunar 4.15.4 and above

closed

mentioned in issue #453 (closed)