Icons, thumbnails and emblems blurred when window scaling set to 2x

added 5. Icons label

I can confirm this bug. It occurs both when running Thunar under Xfce as well as under Mate.

In all other applications running under Xfce, the icons are displayed sharp. Thunar will also display blurred icons when using a SVG based icon theme.

Interestingly, with Thunar handling the Desktop under Xfce, the background image is somewhat blurred as well, no matter what settings are used to scale it. This does not happen with Mate DE, where Caja handles the Desktop. Here, the same background image is displayed sharp.

Ubuntu 20.04, Xfce 4.16, Thunar 4.16.2 (Xfce 4.16), 4K-Display (3840x2160), Xfce window scaling set to 2x

Please let me know if I may assist in debugging.

Cheers, r.

mentioned in issue #481 (moved)

mentioned in issue xfdesktop#111 (closed)

A short follow-up after @alexxcons pointed me to Issue #45:

I've tried the same with Thunar, launched from a terminal:

GDK_SCALE=1 GDK_DPI_SCALE=1 thunar &

will give me a Thunar with small icons and tiny fonts, while

GDK_SCALE=1 GDK_DPI_SCALE=2 thunar &

will open Thunar with small icons and normal sized fonts.

I need to add the the blurred rendering without these settings don't only affect the icons, but also thumbnails of images, pdf files etc.

Please let me know if I may assist in debugging.

Please let me know if I may assist in debugging.

Currently afaik nobody is looking into this issue. If you are interested, please go ahead, a patch/MR would be very welcome !

added 5. Window Scaling label

Do we have an idea what the technical problem is here? Where do we need to change code? For example is it only a Gtk API thing and we have to change the Gtk API calls? This does not only affect not only Thunar but also the Xfce Panel and Xfdesktop and possibly more programs. Interestingly the Whisker menu doesn't have this problem. All icons are very sharp. So maybe we should compare the Gtk API calls?

Sounds reasonable to compare the icon loading of the whisker menu with the icon loading of the other components !

For thunar the files to check probably are thunar-icon-factory and thunar-icon-renderer.

Can we add the label Hidpi?

added 5. HiDPI Monitor label

I wrote some cheap code. Applying scale factor on thunar_icon_factory_lookup_icon () and executing GDK_SCALE=2 GDK_DPI_SCALE=2 thunar looks like this:

It only changed resolution for toolbar icons, and my method uses GDK_SCALE instead of GDK_DPI_SCALE.

~~Source~~Source, if you want to pick up from my code

P.S.: For someone intereseted, this info may or may not be useful: ExoTreeView is an extension of GtkTreeView but ExoIconView is not an extension of GtkIconView. ExoIconView has its own icon renderer.

Hammering only ThunarIconFactory does not fix the issue. It loads scaled-up icon but somehow those Gtk*View gets scaled-down version and it scales up again?

Just ported the patch to latest master: 0001-gtk_scale-patch.patch

Though I have to say, for me it seems to have a rather negative effect.

Patch aplied on the left, unpatched on the right. Started with GDK_SCALE=2 GDK_DPI_SCALE=2 thunar:

The toolbar for me looks good in both cases, though the shortcut-side-pane looks rather bad now. @MShrimp4 possibly I miss something for the scaling to properly test ? Do I maybe need a hidpi screen for testing ?

I have a 4K screen and window scaling of 2x enabled. I cannot see any improvement with this patch. Here is a screenshot for comparison. The left Thunar window is without patch and the right one has the patch applied:

Thanks for testing @dc_coder_84 ! Since the patch seems not to work, and actually nobody is working on the issue, I'll remove the 4.18 milestone to dont block the release.

@alexxcons Always feel free to contact me whenever you need someone to test Xfce with HiDPI in the future

My knowledge here comes from very little work (and none on this project) so I could be embarrassingly wrong.

@MShrimp4

I think doing icon_size * scale_factor can cause problems when certain icons look different at different sizes. So for the sidebar most themes will have the Desktop look like a picture of an actual desktop at 16px and 24px, and look like a folder at 32px and above (same with Pictures, Videos, etc). So doing 16*2 will give the 32px icon for the sidebar when you really want the 16px scaled up if available.

I think you can avoid manually scaling by using GtkIconTheme.lookup_icon_for_scale (or choose_icon_for_scale or Pixbuf at scale). This should be able to accept the icon name and the scale factor and then return the right icon from the right folder. This should also honor icon themes that support HiDPI.

Just trying it out at scaling factors 1, 2, and 3 gives me:

/usr/share/icons/breeze/mimetypes/16/video-x-generic.svg
/usr/share/icons/breeze/mimetypes/16@2x/video-x-generic.svg
/usr/share/icons/breeze/mimetypes/16@3x/video-x-generic.svg

And for icon themes that don't support HiDPI, it will give the icon multiplied (16, 32, 48 for scaling factor 1, 2, and 3).

changed milestone to %Xfce 4.18

@lastonestanding : I dont plan to fix it for 4.18 .. if you want this issue as 4.18 blocker, than I would expect as well a fix from your side

Since we already have a WIP patch and every small improvement is worth getting in, I'd say that we should keep an eye on this matter for 4.18.

Haha, I know that 'we' Sorry,I realy dont have time to look into it currently. Though I would be happy to review a MR

added Patch label

removed milestone %Xfce 4.18

mentioned in issue xfdesktop#45 (closed)

mentioned in merge request !311 (merged)

Icons, thumbnails and emblems blurred when window scaling set to 2x

Submitted by Theo Linkspfeifer

Description

Designs

Child items ...

Activity