Thunar crashes when switching between tree and shortcut views repeatedly

Submitted by Yousuf Philips @philipzae

Assigned to Xfce Bug Triage

Link to original bug (#16509)

Description

Steps:

1. open thunar
2. press Ctrl + B and then Ctrl + E to switch between shortcut and tree view
3. repeat step 2 until it crashes (should crash on the 8th time)

Confirmed on 1.8.9 and master

Version: 1.8.11

Yousuf Philips @philipzae uploaded an attachment:

Attachment 9545, "backtrace":
thunar_crash_bt.txt

Yousuf Philips @philipzae uploaded an attachment:

Attachment 9548, "backtrace with symbols":
thunar_crash.txt

Alexander Schwinn @alexxcons said:

Thanks for reporting !

For me it is not even required to use Ctrl + B. It's sufficient to hold Ctrl + E to permanently add/remove the tree-view .. same backtrace.

Reuben Green @reubengreen73 said:

I can reproduce this on 1.8.12 and master. The number of changes needed varies quite a bit, but for me it seems to be 20-40. It seems like the crash always happens on Ctrl^B, and when I start thunar again after the crash it opens with tree view in the side pane, so maybe this is a bug somewhere in the chain of code that selects shortcuts view before the change gets saved?

Reproducing this a few times seems to yield the following pattern of errors: I do Ctrl^B and Ctrl^E a few times with no errors printed, until at some point hitting Ctrl^B yields the errors

GLib-GObject-WARNING **: 00:22:58.872: invalid cast from '(null)' to 'GObject' GLib-GObject-CRITICAL **: 00:22:58.872: g_object_set: assertion 'G_IS_OBJECT (object)' failed

after which each Ctrl^E yields

GLib-GObject-WARNING **: 00:23:25.478: invalid unclassed pointer in cast to 'GObject' GLib-GObject-CRITICAL **: 00:23:25.478: g_object_set: assertion 'G_IS_OBJECT (object)' failed

and each Ctrl^B yields

GLib-GObject-CRITICAL **: 00:23:32.777: g_object_unref: assertion 'G_IS_OBJECT (object)' failed GLib-GObject-WARNING **: 00:23:32.796: invalid uninstantiatable type '(null)' in cast to 'GObject' GLib-GObject-CRITICAL **: 00:23:32.796: g_object_set: assertion 'G_IS_OBJECT (object)' failed

and then this pattern repeats until eventually one Ctrl^B yields a segfault.

Reuben Green @reubengreen73 said:

I can also get a crash from just doing Ctrl-E enough times, with similar errors printed to the console.

mentioned in issue #307 (closed)

added 1. Crash / Freeze label

added 1 deleted label

added 5. Side Pane - Shortcuts 5. Side Pane - Tree labels

removed 5. Side Pane - Shortcuts label

Can you still reproduce this crash with version 4.15.2?

Nope, good spot ! Cannot reproduce any more with master, no mater what combination of CTRL+B / CTRL+E is pressed. While I can still reproduce with 1.8.15

Looks like it got fixed somewhat along the road \o/

closed