1.8.x Regression: right-click drag and drop does not show a context menu on drop any more

Submitted by Alexander Schwinn @alexxcons

Assigned to Xfce Bug Triage

Link to original bug (#14583)

Description

Created attachment 7865 screenshot of thunar 1.6.x

In thunar 1.6.x a context menu was shown on drop ( see screenshot )

In thunar 1.8.x this menu does not show any more .. instead the drop is directly executed.

This bug is related to Bug #9625

Attachment 7865, "screenshot of thunar 1.6.x":

Version: git

IMTheNachoMan said:

This bug is still present on Thunar 1.6.15 for me.

$ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"

$ uname -a Linux desk 4.15.0-29-generic #31-Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ thunar -V Thunar 1.6.15 (Xfce 4.12)

Copyright (c) 2004-2015 The Thunar development team. All rights reserved.

Written by Benedikt Meurer benny@xfce.org.

Please report bugs to http://bugzilla.xfce.org/.

Gaelan Lloyd said:

I noticed the same issue. When I start to do a right-click drag, the right-click context menu immediately pops up and prevents you from doing the right-click drag.

Arch Linux, up-to-date. Thunar 1.8.2 (Xfce 4.12)

dev..@..il.com said:

Same problem here.

Thunar 1.8.2 (Xfce 4.12)

(Fedora 29)

Gaelan Lloyd said:

Looks like bug 12348 (reported back in 2015) is related.

Starting the right-click drag of files in Thunar works for me too, as long as you start in any column other than "Name."

Thunar 1.8.2 (Xfce 4.12)

dev..@..il.com said:

If the view in Thunar is set as "View as Icons", right click and drag simply copies the file(s) over to the new location. There is no menu displayed when the files are dropped at the destination.

I have also tried the right-click and drag with the view in Thunar set as "View as Detailed List". I still get no menu when I drag and drop at the new location.

xfce4-about-4.13.4-20.fc29.x86_64 libxfce4util-4.13.2-20.fc29.x86_64 libxfce4ui-4.13.4-20.fc29.x86_64 xfce4-panel-4.13.4-1.fc29.x86_64 xfce4-notifyd-0.4.2-20.fc29.x86_64 xfce4-session-4.13.1-20.fc29.x86_64 xfce4-session-engines-4.13.1-20.fc29.x86_64 xfce4-settings-4.13.5-2.fc29.x86_64 Thunar-1.8.2-1.fc29.x86_64

Alexander Schwinn @alexxcons closed a related bug:

*** Bug 12348 has been marked as a duplicate of this bug. ***

Joji Antony said:

Same problem for me also

$ Thunar --version Thunar 1.8.4 (Xfce 4.12)

Copyright (c) 2004-2015 The Thunar development team. All rights reserved.

Written by Benedikt Meurer benny@xfce.org.

Please report bugs to http://bugzilla.xfce.org/.

dev..@..il.com said:

Upgraded to Thunar-1.8.4-1.fc29.x86_64 (Fedora 29).

There is now no capability to "right click and drag" from one Thunar window to another.

dev..@..il.com said:

Is there any updated information from the maintainer(s) of Thunar?

Theo Linkspfeifer said:

The code for right-click drag handling was removed [1]. Furthermore, the fuction gdk_drag_context_set_suggested_action() is not available anymore, so a replacement is needed. Maybe changing the code [2] to something like this will work:

action = ((gdk_drag_context_get_actions (context) & GDK_ACTION_ASK) != 0)

Lastly, the context menu popup behavior was changed [3], and that results in thunar_dnd_ask() returning 0 immediately.

---

[1] https://git.xfce.org/xfce/thunar/commit/?id=266f3fbd5f0a40382bac06828922317d1eabf67f [2] https://git.xfce.org/xfce/thunar/tree/thunar/thunar-standard-view.c?h=thunar-1.8.4#n3471 [3] https://git.xfce.org/xfce/thunar/commit/thunar/thunar-gtk-extensions.c?id=bc74029cea6ea874d0358570ce5d374e60ed86b8

dev..@..il.com said:

Thanks for the information Theo. It's a shame that this feature has been removed. To me it was a useful feature to have. Is it possible to bring it back at all?

Theo Linkspfeifer submitted a patch:

I gave it try and somewhat managed to bring the functionality back. The first patch fixes the missing context menu popup which should show up after a small delay while not having started a drag event and not having released the pressed mouse button.

Log output of Thunar 1.8.4:

(thunar:27550): Gtk-WARNING **: 01:28:54.830: no trigger event for menu popup

(thunar:27550): Gtk-CRITICAL **: 01:28:54.831: gtk_menu_popup_at_rect: assertion 'GDK_IS_WINDOW (rect_window)' failed

(thunar:27550): Gdk-CRITICAL **: 01:28:54.831: gdk_event_free: assertion 'event != NULL' failed

Patch 8511, "Fix queued context menu popup":
0001-Fix-queued-context-menu-popup.patch

Theo Linkspfeifer submitted a patch:

This is the actual patch for this bug report. However, the first patch is required to prevent a glitch (drag or button press events not properly ending).

Patch 8512, "Restore right-click drag and drop functionality":
0002-Restore-right-click-drag-and-drop-functionality-Bug-14583.patch

Theo Linkspfeifer submitted a patch:

Added a gdk_event_free() to thunar_standard_view_motion_notify_event().

Patch 8513, "Fix queued context menu popup":
0001-Fix-queued-context-menu-popup.patch

Theo Linkspfeifer said:

With the above change I can trigger a segmentation fault in the following scenario:

Drag a file somewhere to an empty space within the same folder and drop it (no file operation). Do it again quickly and immediately close Thunar.

Theo Linkspfeifer said:

Maybe it would be best to just pop up the context menu on button release, and therefore omit problems. It is the current behavior in 1.8 anyway.

With the timer the popup stays open on button release, but not when it was repositioned due to being to close to a screen border. In 1.6 it disappears in both cases. I do not know which behavior is preferred, but I could not find a way to make it consistent.

Alexander Schwinn @alexxcons said:

Works already fine in icon view ! Support for detailed and compact view needed.

I tried to reproduce the seg.fault, you mentioned above I only suceeded once, getting the following: (thunar:8849): thunar-CRITICAL **: thunar_folder_finished: assertion 'folder->content_type_idle_id == 0' failed

However here a different Seg.Fault, which I can reproduce reliably:

• Open thunar, switch to icon view
• copy or move some file via right click
• Switch to detailed view --> Seg. Fault

Theo Linkspfeifer said:

Does removing the following lines from 8513 resolve the seg fault problems?

/* be sure to free any pending drag timer event */ if (G_UNLIKELY (standard_view->priv->drag_timer_event != NULL)) gdk_event_free (standard_view->priv->drag_timer_event);

Theo Linkspfeifer said:

The problem described in comment 16 (long button press menu behavior) is present in Nemo also. Therefore, it may be something that could be investigated later.

darkshadow8880@gmail.com said:

sorry guys for asking but is there any change to get a patched thunar .deb somewhere?