GLib-GObject-CRITICAL in icon view when removing read permissions

Version information

thunar master(f6cbaf52) and 4.20.1

Steps to reproduce

1. mkdir no-read-perms
2. touch no-read-perms/my-file
3. thunar no-read-perms
4. sudo chmod -r no-read-perms/

Current behavior

Console message:

GLib-GObject-CRITICAL \*\*: signal_emit_valist_unlocked: assertion 'signal_id \> 0' failed

Expected outcome

No criticals

Backtrace

#0  g_logv (log_domain=0x7ffff634b660 <str> "GLib-GObject", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7ffff2b6eca0) at ../glib/gmessages.c:1277
#1  0x00007ffff5bd646c in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at ../glib/gmessages.c:1315
#2  0x00007ffff63ae172 in signal_emit_valist_unlocked (instance=0x50e00004ca20, signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>) at ../gobject/gsignal.c:3287
#3  0x00007ffff63ae911 in g_signal_emit_valist (instance=0x50e00004ca20, signal_id=0, detail=0, var_args=0x7ffff2b6ec20) at ../gobject/gsignal.c:3262
#4  g_signal_emit (instance=0x50e00004ca20, signal_id=0, detail=0) at ../gobject/gsignal.c:3582
#5  0x0000555555c0e019 in thunar_list_model_folder_error (folder=0x50c000421240, error=0x5020003c00b0, store=0x50e00004ca20) at thunar-list-model.c:1550
#6  0x00007ffff6375d31 in g_closure_invoke (closure=0x5070001679d0, return_value=<optimized out>, n_param_values=n_param_values@entry=2, param_values=param_values@entry=0x7fffffffd6a0, 
    invocation_hint=invocation_hint@entry=0x7ffff2d19690) at ../gobject/gclosure.c:833
#7  0x00007ffff63b012f in signal_emit_unlocked_R (node=0x7fffffffd7a0, detail=<optimized out>, instance=<optimized out>, emission_return=<optimized out>, 
    instance_and_params=<optimized out>) at ../gobject/gsignal.c:3887
#8  0x00007ffff63ad98d in signal_emit_valist_unlocked (instance=0x50c000421240, signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>) at ../gobject/gsignal.c:3519
#9  0x00007ffff63ae911 in g_signal_emit_valist (instance=0x50c000421240, signal_id=406, detail=0, var_args=0x7ffff2b6dea0) at ../gobject/gsignal.c:3262
#10 g_signal_emit (instance=0x50c000421240, signal_id=406, detail=0) at ../gobject/gsignal.c:3582
#11 0x0000555555b99968 in thunar_folder_error (job=0x50e0000e0b20, error=0x5020003c00b0, folder=0x50c000421240) at thunar-folder.c:673
#12 0x00007ffff6375d31 in g_closure_invoke (closure=0x50700023afb0, return_value=<optimized out>, n_param_values=n_param_values@entry=2, param_values=param_values@entry=0x7fffffffdc60, 
    invocation_hint=invocation_hint@entry=0x7ffff2d19490) at ../gobject/gclosure.c:833
#13 0x00007ffff63b012f in signal_emit_unlocked_R (node=0x7fffffffdd60, detail=<optimized out>, instance=<optimized out>, emission_return=<optimized out>, 
    instance_and_params=<optimized out>) at ../gobject/gsignal.c:3887
#14 0x00007ffff63ad98d in signal_emit_valist_unlocked (instance=0x50e0000e0b20, signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>) at ../gobject/gsignal.c:3519
#15 0x00007ffff63ae911 in g_signal_emit_valist (instance=0x50e0000e0b20, signal_id=411, detail=0, var_args=0x7ffff2b6de20) at ../gobject/gsignal.c:3262
#16 g_signal_emit (instance=0x50e0000e0b20, signal_id=411, detail=0) at ../gobject/gsignal.c:3582
#17 0x00007ffff7e79cd8 in exo_job_error (job=0x50e0000e0b20, error=0x5020003c00b0) at exo-job.c:418
#18 exo_job_async_ready (user_data=0x50e0000e0b20) at exo-job.c:267
#19 0x00007ffff5bc1103 in g_main_dispatch (context=0x511000001800) at ../glib/gmain.c:3357
#20 g_main_context_dispatch_unlocked (context=0x511000001800) at ../glib/gmain.c:4208
#21 0x00007ffff5bc1dd0 in g_main_context_iterate_unlocked (context=0x511000001800, block=<optimized out>, dispatch=<optimized out>, self=<optimized out>) at ../glib/gmain.c:4273
#22 0x00007ffff5bc2026 in g_main_context_iteration (context=context@entry=0x511000001800, may_block=may_block@entry=1) at ../glib/gmain.c:4338
#23 0x00007ffff6137cd2 in g_application_run (application=<optimized out>, argc=<optimized out>, argv=<optimized out>) at ../gio/gapplication.c:2715
#24 0x0000555555a73824 in main (argc=2, argv=0x7fffffffe4a8) at main.c:86

Additional information

Originally reported here: #1441 (comment 94585)

added 5. Icon View label

mentioned in issue #1441 (closed)

added 1. Regression label

I checked the code and noticed that signal_id is always 0. The signal definitions were moved to thunar-standard-view-model.c in 6c032077, so now the list_model_signals array in thunar-list-model.c is not initialized anymore.

Here is a quick test:

diff --git a/thunar/thunar-list-model.c b/thunar/thunar-list-model.c
index 4d5b9869..9d449bf4 100644
--- a/thunar/thunar-list-model.c
+++ b/thunar/thunar-list-model.c
@@ -1650,7 +1650,7 @@ thunar_list_model_folder_error (ThunarFolder    *folder,
   thunar_list_model_set_folder (THUNAR_STANDARD_VIEW_MODEL (store), NULL, NULL);
 
   /* forward the error signal */
-  g_signal_emit (G_OBJECT (store), list_model_signals[THUNAR_STANDARD_VIEW_MODEL_ERROR], 0, error);
+  g_signal_emit_by_name (G_OBJECT (store), "error", error);
 }
 

mentioned in issue #1538

mentioned in merge request !587 (merged)

mentioned in commit 5ef807d4

mentioned in commit 71e17145

changed milestone to %4.20.2

closed

mentioned in issue #302 (closed)