Renaming current folder via location button leads to criticals
Version information
4.19.3git-166ab0f1
Steps to reproduce
- Enable the Shortcuts sidepane and switch to Buttons Style for the location selector
- Rename the current (non empty) folder via its location button context menu
Current behavior
It may take some attempts, but eventually Thunar will generate some criticals (or will segfault when debug flags are set).
Terminal output
(thunar:23706): thunar-CRITICAL **: 18:39:57.192: thunar_folder_get_files: assertion '(((__extension__ ({ GTypeInstance *__inst = (GTypeInstance*) ((folder)); GType __t = ((thunar_folder_get_type ())); gboolean __r; if (!__inst) __r = (0); else if (__inst->g_class && __inst->g_class->g_type == __t) __r = (!(0)); else __r = g_type_check_instance_is_a (__inst, __t); __r; }))))' failed
(thunar:23706): thunar-CRITICAL **: 18:39:57.192: thunar_folder_get_corresponding_file: assertion '(((__extension__ ({ GTypeInstance *__inst = (GTypeInstance*) ((folder)); GType __t = ((thunar_folder_get_type ())); gboolean __r; if (!__inst) __r = (0); else if (__inst->g_class && __inst->g_class->g_type == __t) __r = (!(0)); else __r = g_type_check_instance_is_a (__inst, __t); __r; }))))' failed
(thunar:23706): GLib-GObject-CRITICAL **: 18:39:57.192: invalid (NULL) pointer instance
(thunar:23706): GLib-GObject-CRITICAL **: 18:39:57.192: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(thunar:23706): GLib-GObject-CRITICAL **: 18:39:57.192: invalid (NULL) pointer instance
(thunar:23706): GLib-GObject-CRITICAL **: 18:39:57.192: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(thunar:23706): exo-CRITICAL **: 18:39:57.192: IA__exo_job_launch: assertion '(((__extension__ ({ GTypeInstance *__inst = (GTypeInstance*) ((job)); GType __t = ((IA__exo_job_get_type ())); gboolean __r; if (!__inst) __r = (0); else if (__inst->g_class && __inst->g_class->g_type == __t) __r = (!(0)); else __r = g_type_check_instance_is_a (__inst, __t); __r; }))))' failed
Expected outcome
No criticals or segfault.
Backtrace
#0 0x0000739560f40a1b in g_logv () at /usr/lib/libglib-2.0.so.0
#1 0x0000739560f40c94 in g_log () at /usr/lib/libglib-2.0.so.0
#2 0x00005a81acd40eea in thunar_folder_get_files (folder=folder@entry=0x0) at thunar-folder.c:1183
#3 0x00005a81acd4cc92 in thunar_io_jobs_load_statusbar_text_for_folder
(standard_view=standard_view@entry=0x5a81e0ea8700, folder=0x0) at thunar-io-jobs.c:1993
#4 0x00005a81acd81c90 in thunar_standard_view_update_statusbar_text_idle (data=0x5a81e0ea8700)
at thunar-standard-view.c:2382
#5 thunar_standard_view_update_statusbar_text_idle (data=0x5a81e0ea8700)
at thunar-standard-view.c:2354
Edited by Theo Linkspfeifer