Dialogs: Window icon is missing sometimes

Version information

Thunar 4.19.3 on Xubuntu 24.10

Thunar 4.18.10 on Fedora 40 Xfce

Steps to reproduce

1. In xfwm4, use "Default" window theme
2. In xfwm4, make sure the "Menu" button is active
3. In Thunar, Right Click on file or folder
4. Select "Properties"

Other dialogs affected: "Configure custom actions" "Configure Toolbar" "Select by pattern" "Create Folder" "Rename"

Current behavior

The window icon is missing in many themes. From what I can tell, Thunar seems to look for an icon named Thunar in the icon theme. If not found, a generic window icon is used (I believe from xfwm).

Expected outcome

It should use the newer named app icon, org.xfce.thunar, so that it can fall back to the Thunar-provided hicolor icon if an icon theme doesn't provide it. Another solution, maybe the icon/thumbnail next to "Name" in the dialog could be used. (or possibly document-properties, the icon that Right Click > Properties uses)

Additional information

This shows the dialog uses the Thunar icon when available and not org.xfce.thunar.

Maybe here needs to be changed? It's a simple and trivial thing I can check later but I currently don't have the build tools installed, or the time. I can come back and try when I'm able (if no one else checks it out before then).

changed the description

added 5. Dialogs 5. Icons labels

Thanks for the report.

Maybe here needs to be changed?

Indeed. That line was not changed in 78f73f66 and it should be updated too.

Another solution, maybe the icon/thumbnail next to "Name" in the dialog could be used.

Yes, this would be a nice improvement for the Properties dialog. However, using the file thumbnail as window icon may require some extra code.

(or possibly document-properties, the icon that Right Click > Properties uses)

The document-properties icon is meant for PDF and Office files, so we probably should not use it.

Maybe here needs to be changed?

When changing this line to gtk_window_set_default_icon_name ("org.xfce.thunar");, I always see my home folder icon, e.g. in the preferences' dialog

Showing a thumbnail there IMO would be overkill. As Theo said, document-properties is just not the right icon. I suppose showing the thunar hammer would be the right thing to do.

I can come back and try when I'm able (if no one else checks it out before then).

Happily waiting for that :D

assigned to @newhoa

wayland 1.23.1-1 labwc 0.8.2-1 thunar 4.20.0-1

I don't know if it is related. On labwc the thunar icon is missing.

@newhoa Do you want to open a MR that updates the icon name in the mentioned line? It is a simple fix that we should apply.

mentioned in merge request !592 (merged)

unassigned @newhoa

changed milestone to %4.21.0

Fixed by above MR, closing

closed

changed milestone to %4.20.3

mentioned in commit 18e76172