Search permanently changes view to the list view

Version information

4.19.5git-b94a2a3f, but it happens on 4.18.x, too.

Steps to reproduce

1. Use "Remember view settings for each folder".
2. Use icon view (Ctrl+1).
3. Open subdirectory.
4. Go back.
5. Press "Ctrl+F" in directory with subdirectories.
6. Navigate back/forward few times (you should enter go into directory from point 3 using back/forward buttons).

Current behavior

Directory is displayed as list view instead of icon view.

Expected outcome

Directory is displayed icon view (search must not permanently change the view mode).

bug

Thanks for reporting … however, I cannot reproduce the issue with the described steps

Seems like some relevant detail is missing ... maybe some setting. Could you please attach your ~/.config/xfce4/xfconf/xfce-perchannel-xml/thunar.xml, so that I can test with the same settings you are using?

Attached thunar.xml :)

Still no luck . Some questions regarding the steps:

3. Open subdirectory

Does it matter if icon or list view is used in the subdir?

4. Go back.

In which way? Backspace key on the keyboard? "back" toolbar button or "up" toolbar button?

6. Navigate back/forward few times

By using the back/forward toolbar buttons I guess ?

Checked on another PC with Thunar 4.18.11 - I was able to reproduce, but steps were different (and still unknown - I was just using search and finally this happened).

I noticed also view icon size sometimes clashes with search mode icon size - this can be related (Ctrl+F and Ctrl++ / Ctrl+- changes the search mode icon size, but sometimes it affects the normal view, too, untill you reset saved folder view settings and restart Thunar).

I'll try to give more info when I'll find out what's going on here

I noticed this bug since I use search in Thunar, but never found exact way to reproduce it... I just open again some directories later and I see them in list view mode.

Checked on another PC with Thunar 4.18.11

Checking with 4.18.x does not help here ... there have been some fixes in the search behavior between 4.18 and 4.20pre2 ... so best only test with the latest version.

I'll try to give more info when I'll find out what's going on here

Much appreciated!

Checking with 4.18.x does not help here

Ok.

---

The option "Remember view settings for each folder" must be checked. Maybe a different attempt, please try (4.19.5git-6fe8a78a):

Create test directories: mkdir -p /tmp/a/b/c.

Steps:

• run thunar /tmp/a
• open b subdirectory (double click) - we have icon view mode here
• press Ctrl+F
• from search results open c directory (double click)
• close Thunar window (no need to do back/forward)
• run thunar /tmp/a
• open b subdirectory (double click) - we have list view mode, but it had icon view mode previously

If doesn't happen, repeat steps again (sometimes it happens at second attempt).

I was able to reproduce the issue. The core of the problem seems to be that Thunar saves the current view settings when search mode is activated. However, no metadata should be written in this case.

0001-Do-not-save-view-settings-when-searching-1502.patch

This works, thanks! Do you plan to do MR?

Yes!

added 3. Need Info 5. List View (Detailed View) 5. Searching labels

added Patch label and removed 3. Need Info label

mentioned in merge request !573 (merged)

changed milestone to %4.20.1

closed with merge request !573 (merged)

mentioned in commit 6a88288d

Hmm, only the commit on the xfce-4.20 branch is referenced here, even though the change as well was applied to master (3f8ee52d) ... possibly a gitlab issue

The issue number in the commit title on that page is not clickable either.

Opened an issue for it: https://gitlab.com/gitlab-org/gitlab/-/issues/510868

One day later and now the issue number is a clickable link.

Interesting ... maybe the link to the commit will as well be attached to this issue when waiting few more days