Image Preview panel issues

Version information

Thunar 4.8.11

Calculate Linux (Gentoo-based)

Steps to reproduce. Current behavior

On first activation, image file selected

1. Open Thunar.
2. Turn on View -> Side Pane -> Image Preview.
3. Choose an image file.
4. Expected: the image-preview-panel shows the preview.
5. Actual: the image-preview-panel is broken as such:

On first activation, non-image file selected

1. Open Thunar.
2. Turn on View -> Side Pane -> Image Preview.
3. Choose nothing, or choose a non-image file.
4. Expected: the image-preview-panel is empty.
5. Actual: the image-preview-panel is broken as such:

On second activation

1. Open Thunar.
2. Turn on View -> Side Pane -> Image Preview.
3. Choose an image file.
4. The image-preview-panel is OK.
5. Turn off View -> Side Panel -> Image Preview.
6. Choose a non-image file.
7. Turn on View -> Side Pane -> Image Preview.
8. Expected: the image-preview-panel is empty.
9. Actual: the image-preview-panel shows the p.4 preview.

changed the description

Just tested on master and 4.18: I can reproduce all the cases on 4.18, but they are all fixed for master

Not sure which of the commits make the difference: https://gitlab.xfce.org/xfce/thunar/-/commits/master?search=preview

Thumanizing in general was improved/simplified for master, so I guess most of these patches will not apply on the 4.18. branch, or will not have the desired effect, so before breaking anything for 4.18 on accident, I would prefer to keep the changes on master only.

So closing, since already fixed for master.

closed

added 5. Image Preview label