Undo of rename operation fails when navigating directories before rename

Version information

d9f6e2bf on Arch Linux

Steps to reproduce

1. mkdir -p test-rename/foo/
2. touch test-rename/foo/bar.py
3. thunar test-rename/
4. Enter the foo directory
5. Right-click on bar.py and select Properties...
6. Leave the Properties dialog open and navigate up one directory in Thunar
7. In the Properties dialog, rename bar.py to bar and close the dialog
8. Press ctrl + z to trigger an error: Failed to undo operation 'Rename'

Current behavior

The undo operation fails

Expected outcome

I would expect undo to change the filename back to bar.py. (The undo succeeds in 4.18.10.)

Thanks for reporting.

Can as well be reproduced with rename via F2.

The problem seems to be, that inside thunar_file_rename, thunar_file_reload is not triggered after g_file_set_display_name, when we are in a different folder / the parent folder of the renamed file is not monitored. As a result, the job-operation inside _thunar_io_jobs_rename will receive the old file-name twice.

It looks like the use-cases described in #1080 (closed) , for which this code was added, meanwhile both work fine without that special check for thunar_folder_has_folder_monitor in thunar_file_rename, so it seems to be safe to just drop the check.

TL;DR, here a fix, which hopefully does not create a regression: 0001-Simplify-reload-after-rename-1395.patch

added 5. Undo / Redo label

mentioned in commit cc16fc75

pushed fix to master --> closing

closed

changed milestone to %4.19.3