When `misc-symbolic-icons-in-sidepane` is enabled sometimes symbolic icons appear in list view

Follow-up of !456 (comment 89269)

When misc-symbolic-icons-in-sidepane is enabled, sometimes is possible to see that symbolic icons also appear in list view:

This is easily reproducible when one have shortcuts in the side pane and uses them to navigate back and forth. I was able to reproduce this problem with Papirus, elementary and Adwaita. I was NOT able to reproduce this with icon and compact view.

mentioned in merge request !456 (merged)

added 5. Icons 5. List View (Detailed View) labels

Hmm, what I can see for these themes is, that using very small zoom levels results in symbolic icons. That seems to be desired by theme authors (No idea if that possibly validates the fd.org specification)

Though I fail to reproduce your screenshot, where only specific icons are symbolics, but others are not Possibly you are using fractional scaling ? Could that be related ?

added 3. Need Info label

I think icon theme authors kind of force the icons to be symbolic only for the 16px size.

I don't use fractional scaling, but I found something interesting, the side pane icons have to have the same size as of the main view's icons, now I can reproduce even when using the Icon View:

Maybe the problems is related to caching in the icon factory, it's just not really obvious because wants_symbolic is part of the hash table key.

I still fail to reproduce Which concrete side-pane icon-size and zoom level did you use for the screenshot?

First screenshot 24px, second 48px. You really need to have a folder like that "syncthing" on the shortcuts pane.

To me it's always reproducible if I follow these steps:

• Click on the syncthing shortcut
• Click on the home shortcut
• Click on the download shortcut
• Click on the home shortcy
• The syncthing icon will be symbolic

Ah, finally I can reproduce, thanks. Pressing F5 seems to fix the wrong icons.

You can test with the tree view sidepane also. Simply expand the home folder.

It looks like one line was missing:

0001-Add-symbolic-value-to-cached-icons-1363.patch

Optional code cleanup:

0001-Some-code-cleanup-in-icon-factory.patch

@lastonestanding good one, I confirm that fixes the issue, thanks!

I just noticed one small glitch that is not strictly related to this issue. Toggling the xfconf property during runtime does not update the icons for "File System" and "Browse Network" in the shortcuts pane.

-> !459 (merged)

mentioned in commit a062e3a3

Nice catch! I just pushed the fix.

As well added one line from thunar_icon_key_equal of the second patch, since it was obvious to me that it was missing.

For the remaining lines in the cleanup patch (movement of the if-block), I was not sure if it possibly could have side effects, so I left that out for now.

I just noticed one small glitch that is not strictly related to this issue. Toggling the xfconf property during runtime does not update the icons for "File System" and "Browse Network" in the shortcuts pane.

Yea, as well noticed that one ... not sure if it is worth looking into it. Probably people will figure out that reopen thunar already fixes it.

closed

changed milestone to %4.19.3

removed 3. Need Info label