Incorrect use of g_malloc_n

gcc now warns me about this, I think it's recent (I don't know if the change came from it and/or glib):

  CC       thunar-thunar-tree-view-model.o
thunar-tree-view-model.c: In function 'thunar_tree_view_model_get_path':
thunar-tree-view-model.c:1039:33: warning: 'g_malloc_n' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
 1039 |   indices = g_malloc_n (sizeof (gint), depth);
      |                                 ^~~~
thunar-tree-view-model.c:1039:33: note: earlier argument should specify number of elements, later size of each element
thunar-tree-view-model.c: In function 'thunar_tree_view_model_dir_files_changed':
thunar-tree-view-model.c:2783:43: warning: 'g_malloc_n' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
 2783 |           new_order = g_malloc_n (sizeof (gint), length);
      |                                           ^~~~
thunar-tree-view-model.c:2783:43: note: earlier argument should specify number of elements, later size of each element

They were both introduced in 62051e0e I think, a bit surprised it didn't cause a crash :)

changed the description

Looks like some new gcc feature I don't have it yet.

I suppose this should fix the warn: 0001-Prevent-g_malloc_n-build-warnings.patch

I suppose for our minimal use-case the order does not matter much, since malloc will anyhow multiply the first arg with the seconds and allocate that as one piece of memory.

mentioned in commit 2a2a3c3a

closed

changed milestone to %4.19.3

added 1. Build label