Crash in thunar_shortcuts_model_file_changed

Reproducer:

• Open a window in shortcuts view
• Open a second window, switch to tree-view there
• create a new file in one of the windows (e.g. via right click menu)
• trash that file --> crash

Bug does not show in thunar 4.18.x

Trace:

#0  0x00007ffff7094c79 in g_logv () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007ffff7094f03 in g_log () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007ffff718e540 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3  0x00007ffff71a1afc in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x00007ffff71a3501 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5  0x00007ffff71a9186 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6  0x00007ffff71a9243 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7  0x00005555556364af in thunar_shortcuts_model_file_changed (file=0x555555868690, model=0x5555557fd0e0)
    at thunar-shortcuts-model.c:1743
#8  0x00007ffff718e540 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9  0x00007ffff71a1afc in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#10 0x00007ffff71a3501 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007ffff71a9186 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007ffff71a9243 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x00005555555dc3df in thunar_file_changed_signal_emit (data=0x555555868690) at thunar-file.c:5363
#14 0x00007ffff708d02e in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x00007ffff70890d9 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x00007ffff708c317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#17 0x00007ffff708c930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#18 0x00007ffff72c0b7d in g_application_run () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#19 0x0000555555594927 in main (argc=2, argv=0x7fffffffe088) at main.c:86

changed milestone to %4.19.3

assigned to @alexxcons

changed the description

changed the description

changed the description

added 1. Crash / Freeze 5. Side Pane - Shortcuts labels

added 1. Regression label

changed the description

changed the description

Crash was introduced by 5e729d5f

changed the description

mentioned in commit 75c803af

The ShortcutModel is reused by all ShortcutViews. So we need to disconnect from it manually when the view is finalized.

Fixed by above commit

closed