Undoing permanent deletion of a file or a dir appears to succeed but does something else (or nothing)
Steps to reproduce:
- Create a file or a dir.
- Select it and press Shift+Delete.
- Confirm deletion.
- Undo.
Actual results: a notification appears Undo performed
, Create Folder operation was undone
.
Expected results: either a notification that permanent deletion cannot be undone or an error message that says the folder no longer exists, so its creation cannot be undone.
As it is, if the user doesn't read the notification message carefully, the success can mislead the user into believing the deleted item was restored.
Another issue: if the previous operation was not folder creation but something else, the user might not realize that some old filesystem operation has been undone, until it is too late to redo the operation.
Fix implementation ideas:
- insert a dummy error-message action into the undo/redo queue and show a notification with an error or warning icon. The notification text could be
Cannot undo permanent deletion
; - or clear the undo/redo queue when an action that cannot be undone is performed.