Skip to content

Fix XfwMonitor leak in steal_monitor_by_connector

correctmost requested to merge correctmost/libxfce4windowing:cm/fix-monitor-leak into main

Leak report

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x76ca954fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x76ca912b950d in g_malloc glib/gmem.c:100
    #2 0x76ca9131cddc in g_slice_alloc glib/gslice.c:193
    #3 0x76ca91282a84 in g_list_prepend glib/glist.c:253
    #4 0x76ca952092d7 in enumerate_monitors libxfce4windowing/xfw-monitor-x11.c:485
    #5 0x76ca952092d7 in refresh_monitors libxfce4windowing/xfw-monitor-x11.c:511
    #6 0x76ca9520a57c in _xfw_monitor_manager_x11_new libxfce4windowing/xfw-monitor-x11.c:666
    #7 0x76ca9520bf45 in xfw_screen_x11_constructed libxfce4windowing/xfw-screen-x11.c:125
    #8 0x76ca90b820d9 in g_object_new_internal gobject/gobject.c:2657
    #9 0x76ca90b879cb in g_object_new_valist gobject/gobject.c:2945
    #10 0x76ca90b8911b in g_object_new gobject/gobject.c:2418
    #11 0x76ca951f782f in xfw_screen_get libxfce4windowing/xfw-screen.c:585
    #12 0x76ca951f782f in IA__xfw_screen_get_default libxfce4windowing/xfw-screen.c:623
    #13 0x5856e791370c in xfsm_manager_init /home/s/code/xfce4-session/xfce4-session/xfsm-manager.c:205
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports