Skip to content
Snippets Groups Projects

Remove xfw_(window|application)_get_id() and add xfw_window_get_xid()

All threads resolved!

@Tamaranch does this look ok to you? I feel like I might be missing something for the docs, as I always forget something there...

I think I'm going to hold off on adding xfw_window_wayland_get_foreign_toplevel_handle(), since presumably at some point we'll support both the wlr-foreign-toplevel-management as well as ext-foreign-toplevel-list (plus whatever other ext- protocol ends up being standardized to manage them).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Brian Tarricone

      At first glance, I'm not thrilled about reintroducing an X11/Wayland distinction, but it's true that X11's get_xid() has no Wayland equivalent and is useful. In fact, I just remembered that I currently use get_id() in docklike's Wayland porting MR (in X11-only code, to use gdk_x11_window_foreign_new_for_display()). (And I realize now that I use it in several places in the panel, and that you also use it in xfdesktop, so ok, definitely useful!)

      Apart from the fact that, on Wayland, the window could have several ids from different protocols, I don't see the point of exposing them, since the user can't do anything with them (especially not connect listeners). But that's another story, maybe we'll have some Wayland-only things that will be useful to expose in the future.

      Looks good to me otherwise, documentation included :)

      Edited by Gaël Bonithon
  • added 1 commit

    • 7dc8fc3b - Add an X11-specific header and xfw_window_get_xid()

    Compare with previous version

  • Ok, removed the new header from EXTRA_DIST, and added a libxfce4windowing-x11-0.pc file.

  • added 1 commit

    • 40d38a4d - Add an X11-specific header and xfw_window_get_xid()

    Compare with previous version

  • Brian Tarricone resolved all threads

    resolved all threads

  • added 3 commits

    • a3fd1449 - 1 commit from branch xfce:main
    • d7d9bae6 - Remove xfw_(window|application)_get_id()
    • 37d26946 - Add an X11-specific header and xfw_window_get_xid()

    Compare with previous version

  • Brian Tarricone enabled an automatic merge when the pipeline for 37d26946 succeeds

    enabled an automatic merge when the pipeline for 37d26946 succeeds

  • Gaël Bonithon changed milestone to %4.19.3

    changed milestone to %4.19.3

  • Please register or sign in to reply
    Loading