Skip to content

Call xfce_kiosk's parent finalizer to prevent leaks

correctmost requested to merge correctmost/libxfce4util:cm/fix-kiosk-leak into master

Leak report

Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x7ef5884fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7ef5842b950d in g_malloc glib/gmem.c:100
    #2 0x7ef584211023 in datalist_append glib/gdataset.c:170
    #3 0x7ef584212489 in g_data_set_internal glib/gdataset.c:509
    #4 0x7ef584212ee1 in g_datalist_id_set_data_full glib/gdataset.c:792
    #5 0x7ef583b7727e in g_object_notify_queue_create_queue_frozen gobject/gobject.c:674
    #6 0x7ef583b7746c in g_object_notify_queue_freeze gobject/gobject.c:689
    #7 0x7ef583b7f101 in g_object_unref gobject/gobject.c:4412
    #8 0x7ef5882f7155 in xfce_kiosk_free libxfce4util/libxfce4util/xfce-kiosk.c:232
    #9 0x56db25b66d04 in xfsm_shutdown_init xfce4-session/xfce4-session/xfsm-shutdown.c:139
    #10 0x7ef583bec742 in g_type_create_instance gobject/gtype.c:1951
    #11 0x7ef583b81fc7 in g_object_new_internal gobject/gobject.c:2606
    #12 0x7ef583b86e2d in g_object_new_with_properties gobject/gobject.c:2769
    #13 0x7ef583b89189 in g_object_new gobject/gobject.c:2415
    #14 0x56db25b66f18 in xfsm_shutdown_get xfce4-session/xfce4-session/xfsm-shutdown.c:192
    #15 0x56db25b52531 in xfsm_manager_init xfce4-session/xfce4-session/xfsm-manager.c:195
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports