Skip to content

menu-item: Fix string leaks in garcon_menu_item_reload_from_file

correctmostrequested to merge
correctmost/garcon:cm/fix-str-leaks into master

Leak report

Direct leak of 17 byte(s) in 1 object(s) allocated from:
    #0 0x7f3b0f772fc5 in malloc /usr/src/debug/compiler-rt/compiler-rt-20.1.6.src/lib/asan/asan_malloc_linux.cpp:67:3
    #1 0x7f3b0f398852 in g_malloc glib/glib/gmem.c:100:13
    #2 0x7f3b0f41a5c3 in g_strndup glib/glib/gstrfuncs.c:419:17
    #3 0x7f3b0f41a5c3 in g_strsplit glib/glib/gstrfuncs.c:2422:41
    #4 0x7f3b0ef03e7b in xfce_rc_read_list_entry libxfce4util/libxfce4util/xfce-rc.c:707:14
    #5 0x7f3b0799fa8c in garcon_menu_item_reload_from_file garcon/garcon/garcon-menu-item.c:1286:14
    #6 0x7f3b0799e901 in garcon_menu_item_reload garcon/garcon/garcon-menu-item.c:1083:10
    #7 0x7f3b079d0af7 in garcon_menu_process_file_changes garcon/garcon/garcon-menu.c:2338:23
    #8 0x7f3b0f35d5bf in g_idle_dispatch glib/glib/gmain.c:6411:15
    #9 0x7f3b0f372fbc in g_main_dispatch glib/glib/gmain.c:3524:27
    #10 0x7f3b0f372fbc in g_main_context_dispatch_unlocked glib/glib/gmain.c:4375:7
    #11 0x7f3b0f3741dd in g_main_context_iterate_unlocked glib/glib/gmain.c:4440:5
    #12 0x7f3b0f374f24 in g_main_loop_run glib/glib/gmain.c:4642:5
    #13 0x7f3b0e818569 in gtk_main gtk/gtk/gtkmain.c:1329:7
    #14 0x55ea44afdce5 in main xfce4-panel/wrapper/main.c:366:7

Steps to reproduce

  • I triggered the leaks by running sudo pacman -R code && sudo pacman -S code

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports