Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • garcon garcon
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • garcongarcon
  • Merge requests
  • !22

garcon-menu-separator: Fix constructor

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Gaël Bonithon requested to merge Tamaranch/garcon:fix-separator into master Apr 13, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

This partially reverts 1045e3f0, where the static qualifier was removed without reason and without making the rest of the function consistent with this change. The GarconMenuSeparator is not intended to be packed in a container, so it can effectively be created once and then only referenced.

This also fixes a memory leak reported by Valgrind on the weak reference added on separator, which did not make sense anymore with a non-static variable.

Related: !5 (merged)

Edited May 15, 2022 by Gaël Bonithon
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-separator