Skip to content
Snippets Groups Projects

Thunar crashes when typing in URL bar

    • Closed Issue created by mikhailnov @mikhailnov

    I click ctrl+L, start typing URL manually and sometimes (I can't understand when exactly) thunar 4.16.6 crashes:

    [user@rosa2019 ~]$ GTK_THEME=Adwaita LC_ALL=C.UTF-8 thunar

(thunar:18486): thunar-WARNING **: 10:52:30.841: Name 'org.freedesktop.FileManager1' lost on the message dbus.
**
Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)
Bail out! Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)
Аварийный останов (стек памяти сброшен на диск)

    I tried Adwaita theme above, but the same happens with different GTK+3 themes.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    • mikhailnov
      mikhailnov @mikhailnov ·
      Author 
      [user@rosa2019 ~]$ rpm -q gtk+3.0
gtk+3.0-3.24.25-2.x86_64
[user@rosa2019 ~]$ rpm -q --whatprovides 'libglib-2.0.so.0()(64bit)'
lib64glib2.0_0-2.66.7-1.x86_64
[user@rosa2019 ~]$
      Edited by mikhailnov
    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      Hm, exo is 4.16.0, not 4.16.1, I will try to update it.

      Backtrace:

      [user@rosa2019 ~]$ gdb --args thunar
GNU gdb (GDB) 9.0.90-1 (ROSA Desktop Fresh R12 release 2019.1)
<...>
Reading symbols from thunar...
Reading symbols from /usr/lib/debug/usr/bin/thunar-4.16.6-1.x86_64.debug...
(gdb) run
Starting program: /usr/bin/thunar 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7ffff5c55640 (LWP 18722)]
[New Thread 0x7ffff5454640 (LWP 18723)]
[New Thread 0x7fffeffff640 (LWP 18724)]
[New Thread 0x7fffef7fe640 (LWP 18725)]
[Thread 0x7fffef7fe640 (LWP 18725) exited]
[New Thread 0x7fffef7fe640 (LWP 18727)]

(thunar:18718): thunar-WARNING **: 10:58:32.138: Имя "org.freedesktop.FileManager1" потеряно в сообщении dbus.
[Thread 0x7fffeffff640 (LWP 18724) exited]
**
Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)
Bail out! Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)

Thread 1 "thunar" received signal SIGABRT, Aborted.
0x00007ffff6f07397 in raise () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff6f07397 in raise () at /lib64/libc.so.6
#1  0x00007ffff6eed538 in abort () at /lib64/libc.so.6
#2  0x00007ffff70e7dcc in g_assertion_message_expr.cold () at /usr/lib64/libglib-2.0.so.0
#3  0x00007ffff714501b in g_assertion_message_expr () at /usr/lib64/libglib-2.0.so.0
#4  0x00007ffff789cde7 in gtk_cell_renderer_get_aligned_area () at /usr/lib64/libgtk-3.so.0
#5  0x00007ffff7f7788b in exo_icon_view_calculate_item_size.part () at /usr/lib64/libexo-2.so.0
#6  0x00007ffff7f7838c in exo_icon_view_layout () at /usr/lib64/libexo-2.so.0
#7  0x00007ffff7f7896c in layout_callback () at /usr/lib64/libexo-2.so.0
#8  0x00007ffff7677dd9 in gdk_threads_dispatch () at /usr/lib64/libgdk-3.so.0
#9  0x00007ffff711ca8f in g_main_context_dispatch () at /usr/lib64/libglib-2.0.so.0
#10 0x00007ffff711ce38 in g_main_context_iterate.constprop () at /usr/lib64/libglib-2.0.so.0
#11 0x00007ffff711ceef in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0
#12 0x00007ffff7332495 in g_application_run () at /usr/lib64/libgio-2.0.so.0
#13 0x0000000000420932 in main (argc=1, argv=0x7fffffffd948) at main.c:86
(gdb)
      Edited by mikhailnov
    • Theo Linkspfeifer
      Theo Linkspfeifer @lastonestanding ·
      Developer

      The same backtrace can be seen here also: https://bugzilla.xfce.org/show_bug.cgi?id=16465#c5

      I have not encountered this crash or noticed the warning yet, so we need to figure out what exactly triggers the bug.

    • Theo Linkspfeifer added 1. Crash / Freeze label

      added 1. Crash / Freeze label

    • Alexander Schwinn
      Alexander Schwinn @alexxcons ·
      Maintainer

      `> assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)

      Maybe we have to prepare our aligned_area in some way before feeding it into gtk_cell_renderer_get_aligned_area, so that we can pass that assertion (allign_area as sub-area of cell_area)? Currently we just feed it with some empty aligned_area (code).

      However, that would be strange, since the purpose of the method actually is to fill the aligned_area. So it makes perfect sense to pass an uninitialized variable. Possibly we should check the related gtk code.

      Edited by Alexander Schwinn
    • Alexander Schwinn
      Alexander Schwinn @alexxcons ·
      Maintainer

      Maybe that (from the gtk sources):

      /* Default implementation assumes that a cell renderer will never use more
 * space than its natural size (this is fine for toggles and pixbufs etc
 * but needs to be overridden from wrapping/ellipsizing text renderers) */
static void
gtk_cell_renderer_real_get_aligned_area ( ...

      Problem could be, that we use the default renderer for wrapping/ellipsizing. At least it looks like exo only uses a custom renderer for icons. Possibly we have to add another renderer.

      On the other side, I would expect more frequent crashes (or at least CTK-CRITICALS) in that case.

      Edited by Alexander Schwinn
    • Alexander Schwinn
      Alexander Schwinn @alexxcons ·
      Maintainer

      A long while back, Thunar used to have a text renderer, which iirc was dropped during the gtk3 port: https://gitlab.xfce.org/xfce/thunar/-/blob/xfce-4.12/thunar/thunar-text-renderer.c

      Possibly we still need a foreign text renderer like that.

    • Alexander Schwinn mentioned in issue #56 (closed)

      mentioned in issue #56 (closed)

    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      exo 4.16.1 has the same problem. More debug:

      Thread 1 "thunar" hit Breakpoint 1, exo_icon_view_calculate_item_size (icon_view=icon_view@entry=0xc5c3e0, item=item@entry=0x97a700) at exo-icon-view.c:3571
3571	            gtk_cell_renderer_get_aligned_area (info->cell, GTK_WIDGET (icon_view),
(gdb) p cell_area
$218 = {x = 2147483647, y = 0, width = 97, height = 22}
(gdb) p aligned_area
$219 = {x = 12960736, y = 0, width = 0, height = 0}
(gdb) c
Continuing.
**
Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)
Bail out! Gtk:ERROR:gtkcellrenderer.c:1796:gtk_cell_renderer_get_aligned_area: assertion failed: (aligned_area->x >= cell_area->x && aligned_area->x <= cell_area->x + cell_area->width)

Thread 1 "thunar" received signal SIGABRT, Aborted.
0x00007ffff6f07397 in raise () from /lib64/libc.so.6

      So, yes, it looks like sth like "more space than its natural size"

      But what is it? Is it calculation for some icons? What is the easiest way to track which icon it is?

      Note for myself:

      $ sleep 5; while true; do xdotool key p; xdotool key space; for i in c e l l underscore a r e a ; do xdotool key $i ; done; xdotool key KP_Enter; xdotool key p; xdotool key space; for i in a l i g n e d underscore a r e a ; do xdotool key $i ; done; xdotool key KP_Enter; xdotool key c ; xdotool key KP_Enter; done
      • Alexander Schwinn
        Alexander Schwinn @alexxcons ·
        Maintainer

        But what is it? Is it calculation for some icons? What is the easiest way to track which icon it is?

        My assumption would be, that it is not an icon, but a wrapped text-string which causes the crash .. though that is just an assumption. And it does not explain well why that crash happens for you while you type something into the URL bar.

        Maybe it only happens for specific folders for you? Possibly file-names are wrapped there ?

      • mikhailnov
        mikhailnov @mikhailnov ·
        Author

        Maybe it only happens for specific folders for you? Possibly file-names are wrapped there ?

        Well, I can type either a local file name or start typing: "sftp://...", type: "sf", and it crashes. In other cases it crashes in other moments. Also seems that there is a microfreeze before crash. I saw that freeze in gdb better than without it.

      • Please register or sign in to reply
    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      I tried typing not existing paths, sometimes it crashes, sometimes it does not.

    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      @alexxcons How can the exact answer be found via debugger?

    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      Thunar 4.17.1 does NOT crash. Seems that bibisecting is required to make a backport to stable 4.16.x

    • mikhailnov
      mikhailnov @mikhailnov ·
      Author

      Very strange, I rebooted and it (thunar 4.17.1) crashes again.

    • Alexander Schwinn
      Alexander Schwinn @alexxcons ·
      Maintainer

      @alexxcons How can the exact answer be found via debugger?

      I dont know it the debugger can be of help here. Sure, you can do gdb thunar/thunar in the source folder and add a breakpoint in the method above exo_icon_view_calculate_item_size. But that most likely will only show what we already know.

      If I would be able to reproduce, I rather would try to disable URL bar features one by one. E.g: Does it as well crash without auto-complete ? Put a printf in all the callbacks of thunar-path-entry, to see which methods are triggered while writing letters.

    • Alexander Schwinn mentioned in issue thunar#545 (closed)

      mentioned in issue thunar#545 (closed)

    • Yongha Hwang
      Yongha Hwang @MShrimp4 ·
      Maintainer

      I tried to reproduce this bug, and while I couldn't reproduce the crash, typing an URL did make thunar freeze for a moment. (I typed https://google.com and thunar freezes after https://.) Maybe freezing and crash is a different issue triggered by similar situation.

    • Theo Linkspfeifer moved from thunar#541 (moved)

      moved from thunar#541 (moved)

    • Evangelos Foutras mentioned in issue thunar#556 (closed)

      mentioned in issue thunar#556 (closed)

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply