Skip to content

Truncation of names in ExoIconView

Commit aa3971c4 seems to introduce a bug in ExoIconView which causes item names to be truncated when displayed in icon view in thunar in a way that seems incorrect to me. I cannot work out how to reproduce this, but as far as I can see it only affects directories and then only very rarely. However, I am basing this on just a few examples only so I could be wrong. Also, this bug seems to only appear when zoomed out more than the default view setting.

EDIT: So the following steps reliably reproduce this bug for me. Open Thunar and set the view to icon mode. Zoom out one level from normal size. Create a new empty directory, and in that directory create a sub-directory with the name "a - bbbbb bbbbbb". The new directory's name will be displayed as "a - [linebreak] bbbbb". Similar names often also produce this bug, as long as they are of the form "X - Y Z" where X Y and Z are strings of letters and Y and Z have different lengths.

For example, I have a directory that looks like this when viewed at normal zoom in thunar using icon view image1

But when I zoom out one step, it looks like thisimage2

If I rename the first directory from "A - Linear Algebra" to eg "A - Linear Algebra aaa", then the bad truncation disappears for all of the items in the directory, and I see this image3 After this renaming, the bad truncation does not reappear if I reload the view, navigate away and back again, or even close and reopen thunar.

The bad truncation appears consistently whenever I view this directory or a copy of it in icon view in thunar when zoomed out more than one level relative to the default zoom, and does not disappear if I reload the view. I have seen it in a few other cases as well, but I cannot see a pattern.

I have had a look at the commit, but I cannot easily see the problem. @andreldm, do you have any thoughts on this? The above example was done with current thunar master and exo master.

Edited by Reuben Green
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information