When multiple items are selected in an ExoIconView and one of them is left-clicked, the selection is not reduced to just that item. This behaviour is inconsistent with both ExoTreeView and GtkIconView.
Edited
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related.
Learn more.
In order to further isolate the problem: Directly returning in thunar_window_set_directory_specific_settings, or disabling directory specific settings fixes the bug.
I suppose that line above only triggers the problem, and it was introduced in one of the previous commits, since the commit actually does not look suspicious.
Right, unless I've messed something up (which is very possible - there are lots of moving parts here!), I can reproduce this in icon view with Thunar 1.8.12 (which is before bug 2487 was fixed) and 58dc79af (which is the commit before the ones you mentioned, Theo).
Reading the comments near the end of bug 2487, I see that I was saying that this was an exo bug, and that I would look into it more carefully and open a bug in exo ... which I did not do, sorry!
Yes, I have started looking at it. I've got a bit distracted trying to understand how gtk, exo, and thunar all interact in creating the whole "selecting and activating files" interface, as this seems to be a big source of problems and I'm hoping I might be able to do some bigger improvements to the code to make it nicer and more maintainable.
But I should probably focus on fixing this bug first, so I'll have a go at that now :)
On the subject of this and similar bugs, I remember a while back there was some talk on IRC about dissolving exo and merging it into the other xfce libraries and programs. Does anyone know if that resulted in any decisions?
I ask because I think I'm right in saying Thunar is the only component that uses the exo views in select-multiple mode, so if getting rid of exo is a thing that might happen then maybe that code could just be merged into Thunar to make things simpler?
I dont know the internals, though if you think you can move parts of the code into thunar without breaking other application which use exo, I would be ok with it.
Though I am not sure if it would pay of .. there probably will be new bugs, caused by the changes.
Theo Linkspfeiferchanged title from Regression: Click on file while other files are selected should select only the clicked file to Click on file while other files are selected should select only the clicked file
changed title from Regression: Click on file while other files are selected should select only the clicked file to Click on file while other files are selected should select only the clicked file
So the underlying problem here is a bug in ExoIconView. ExoIconView does not reduce the selection to just the clicked file in the event of a single click. Reducing the selection on a click is what GtkIconView, GtkTreeView, and ExoTreeView does, so I think ExoIconView should do the same. I'll modify the bug description here and I'll have a go at fixing it, although it looks like this might take a bit of work.
Meanwhile, it was quite easy to write a work-around for Thunar, which you can see here. I have not done a merge-request for this yet, as I want to give it a bit of testing first (I don't want to e.g. break multi-file drag-and-drop again :) ).