Skip to content

tsp-page: Fix string leak in tsp_page_set_error

correctmost requested to merge correctmost/thunar-shares-plugin:cm/fix-error-msg-leak into master

Leak report

Direct leak of 197 byte(s) in 1 object(s) allocated from:
    #0 0x770cdc6fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x770cd7497438  (/usr/lib/libc.so.6+0x88438)
    #2 0x770cdc687d98 in vasprintf /usr/src/debug/gcc/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:1680
    #3 0x770cd87ea5af in g_vasprintf glib/gprintf.c:341
    #4 0x770cd8721cb0 in g_strdup_vprintf glib/gstrfuncs.c:511
    #5 0x770cd8721e40 in g_strdup_printf glib/gstrfuncs.c:541
    #6 0x770ccc6166c9 in tsp_page_set_error thunar-shares-plugin/thunar-plugin/tsp-page.c:530
    #7 0x770ccc6179e5 in tsp_page_file_changed thunar-shares-plugin/thunar-plugin/tsp-page.c:372
    #8 0x770ccc618256 in tsp_page_set_file thunar-shares-plugin/thunar-plugin/tsp-page.c:330
    #9 0x770ccc618569 in tsp_page_set_property thunar-shares-plugin/thunar-plugin/tsp-page.c:278
    #10 0x770cd7f7a8a7 in object_set_property gobject/gobject.c:2172
    #11 0x770cd7f8276f in g_object_new_internal gobject/gobject.c:2664
    #12 0x770cd7f879cb in g_object_new_valist gobject/gobject.c:2945
    #13 0x770cd7f8911b in g_object_new gobject/gobject.c:2418
    #14 0x770ccc617c4c in tsp_page_new thunar-shares-plugin/thunar-plugin/tsp-page.c:290
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports