2006-02-01 Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-properties-dialog.c: Don't recreate plugin pages if
	  the file changes, but instead let the plugins connect to the file's
	  "changed" signal and update their user interface appropriately.
	  Bug #1355.




(Old svn revision: 19707)

ChangeLog

+2006-02-01	Benedikt Meurer <benny@xfce.org>
+
+	* thunar/thunar-properties-dialog.c: Don't recreate plugin pages if
+	  the file changes, but instead let the plugins connect to the file's
+	  "changed" signal and update their user interface appropriately.
+	  Bug #1355.
+
 2006-02-01	Benedikt Meurer <benny@xfce.org>
 
 	* thunar/thunar-file.{c,h}, thunarx/thunarx-file-info.{c,h},

thunar/thunar-properties-dialog.c

@@ -753,9 +753,6 @@ thunar_properties_dialog_update (ThunarPropertiesDialog *dialog)
       gtk_widget_hide (dialog->size_label);
     }
 
-  /* update the provider property pages */
-  thunar_properties_dialog_update_providers (dialog);
-
   /* cleanup */
   g_object_unref (G_OBJECT (icon_factory));
 }
@@ -863,6 +860,10 @@ thunar_properties_dialog_set_file (ThunarPropertiesDialog *dialog,
   g_return_if_fail (THUNAR_IS_PROPERTIES_DIALOG (dialog));
   g_return_if_fail (file == NULL || THUNAR_IS_FILE (file));
 
+  /* check if we already display that file */
+  if (G_UNLIKELY (dialog->file == file))
+    return;
+
   /* disconnect from any previously set file */
   if (dialog->file != NULL)
     {
@@ -893,6 +894,9 @@ thunar_properties_dialog_set_file (ThunarPropertiesDialog *dialog,
 
       /* update the UI for the new file */
       thunar_properties_dialog_update (dialog);
+
+      /* update the provider property pages */
+      thunar_properties_dialog_update_providers (dialog);
     }
 
   /* tell everybody that we have a new file here */