Skip to content
Snippets Groups Projects
  1. Apr 19, 2020
  2. Jan 01, 2020
  3. Jul 30, 2019
  4. Apr 14, 2019
  5. Sep 18, 2018
    • Jehan's avatar
      Right mouse click will not display icons for custom actions. · 8349a54d
      Jehan authored and Alexander Schwinn's avatar Alexander Schwinn committed
      (Bug #14685)
      
      g_icon_to_string() is not meant to return an icon name, it returns a
      "textual representation of the icon", which is mostly "proprietary to
      GIcon" (in GIO documentation's own words).
      In particular the reverse function to get a GIcon back from this
      representation is g_icon_new_for_string().
      
      The reason why it used to work was because of a special casing (which
      happens to be the most common case: when you create an icon with a
      single name); yet even if the most common, relying on special cases is a
      bad idea. The special case is about to be reinstated in GLib so it will
      work again as expected, yet only until the next time a widget uses a not
      special-cased GIcon, for instance if using fallback icons. It is better
      to really fix the code.
      
      Now the menu properly recreates the icon using g_icon_new_for_string(),
      not assuming what type of icons it was (it could be an icon name, a
      path, a list of icon names, or whatever else proprietary representation
      any type of icon may use now or in the future).
      Also update the doc of thunarx_menu_item_new() to explicitly states that
      the icon parameter is a textual representation as returned by
      g_icon_to_string(). In particular this won't break any plug-ins as
      single icon names and icon paths are proper representations for icons
      too.
      8349a54d
  6. Jun 02, 2018
  7. Dec 14, 2017
  8. Dec 11, 2017
  9. Dec 10, 2017
  10. Dec 06, 2017
  11. Nov 25, 2017
  12. Nov 22, 2017
  13. Nov 19, 2017
  14. Nov 05, 2017
  15. Nov 04, 2017
  16. Nov 02, 2017
  17. Sep 18, 2017
  18. Aug 26, 2017
  19. Aug 15, 2017
  20. May 22, 2015
  21. Mar 27, 2015
  22. Jan 06, 2013
  23. Dec 05, 2012
  24. Nov 21, 2012
  25. Nov 04, 2012
  26. Oct 22, 2012
  27. Sep 30, 2012
  28. Sep 27, 2012
  29. Sep 26, 2012
  30. Sep 25, 2012
  31. Sep 16, 2012
  32. Apr 14, 2012
  33. Apr 04, 2012
Loading