Skip to content

Fix GHashTable leak in Settings::load

correctmost requested to merge correctmost/xfce4-whiskermenu-plugin:cm/fix-hashtable-leak into main

Leak report

311 (96 direct, 215 indirect) bytes in 1 blocks are definitely lost in loss record 12,000 of 12,801
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5440661: g_malloc (gmem.c:100)
   by 0x54587DB: g_slice_alloc (gslice.c:193)
   by 0x54274EF: g_hash_table_new_full (ghash.c:1021)
   by 0x571C68A: xfconf_gvariant_to_hash (xfconf-gvaluefuncs.c:678)
   by 0x571786F: xfconf_channel_get_properties (xfconf-channel.c:751)
   by 0x70E40F0: WhiskerMenu::Settings::load(char const*) (settings.cpp:318)
   by 0x70DB88C: WhiskerMenu::Plugin::Plugin(_XfcePanelPlugin*) (plugin.cpp:67)
   by 0x70DBE66: whiskermenu_construct (plugin.cpp:37)
   by 0x70DDB87: xfce_panel_module_realize (register-plugin.c:22)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports