Skip to content

Fix string leak in is_separator

correctmost requested to merge correctmost/xfce4-whiskermenu-plugin:cm/fix-separator-leak into main

Leak report

572 bytes in 12 blocks are definitely lost in loss record 12,296 of 12,809
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5440661: g_malloc (gmem.c:100)
   by 0x5459DD3: g_strdup (gstrfuncs.c:323)
   by 0x53C2A26: g_strdup_inline (gstrfuncs.h:321)
   by 0x53C2A26: value_lcopy_string (gvaluetypes.c:315)
   by 0x4C07AF8: gtk_tree_model_get_valist (gtktreemodel.c:1812)
   by 0x4C07CE4: gtk_tree_model_get (gtktreemodel.c:1774)
   by 0x70D8D96: is_separator(_GtkTreeModel*, _GtkTreeIter*, void*) (launcher-tree-view.cpp:35)
   by 0x4C2ED89: row_is_separator (gtktreeview.c:3113)
   by 0x4C2ED89: gtk_tree_view_bin_draw (gtktreeview.c:5177)
   by 0x4C2ED89: draw_bin (gtktreeview.c:5638)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports