Skip to content

Fix leaks in pulseaudio_volume_connect

correctmost requested to merge correctmost/xfce4-pulseaudio-plugin:cm/fix-volume-leaks into master

Leak report

1,528 (1,072 direct, 456 indirect) bytes in 1 blocks are definitely lost in loss record 9,642 of 9,881
   at 0x484BC13: calloc (vg_replace_malloc.c:1675)
   by 0x71256C3: pa_xmalloc0 (xmalloc.c:74)
   by 0x71D39F4: pa_hashmap_new_full (hashmap.c:61)
   by 0x70CCB96: pulseaudio_volume_connect (pulseaudio-volume.c:628)
   by 0x70CCD8D: pulseaudio_volume_init (pulseaudio-volume.c:208)
   by 0x53BC768: g_type_create_instance (gtype.c:1951)
   by 0x539EF87: g_object_new_internal (gobject.c:2606)
   by 0x53A082D: g_object_new_with_properties (gobject.c:2769)
   by 0x53A166E: g_object_new (gobject.c:2415)
   by 0x70CE566: pulseaudio_volume_new (pulseaudio-volume.c:1160)
   by 0x70D1CBF: pulseaudio_plugin_construct (pulseaudio-plugin.c:566)
[...snip...]

25,077 (328 direct, 24,749 indirect) bytes in 1 blocks are definitely lost in loss record 8,657 of 8,666
   at 0x484BC13: calloc (vg_replace_malloc.c:1675)
   by 0x71256C3: pa_xmalloc0 (xmalloc.c:74)
   by 0x710059E: UnknownInlinedFun (xmalloc.h:75)
   by 0x710059E: pa_context_new_with_proplist (context.c:140)
   by 0x70CCC0A: pulseaudio_volume_connect (pulseaudio-volume.c:636)
   by 0x70CCD8D: pulseaudio_volume_init (pulseaudio-volume.c:208)
   by 0x53BC768: g_type_create_instance (gtype.c:1951)
   by 0x539EF87: g_object_new_internal (gobject.c:2606)
   by 0x53A082D: g_object_new_with_properties (gobject.c:2769)
   by 0x53A166E: g_object_new (gobject.c:2415)
   by 0x70CE566: pulseaudio_volume_new (pulseaudio-volume.c:1160)
   by 0x70D1CE2: pulseaudio_plugin_construct (pulseaudio-plugin.c:575)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports