Skip to content
Snippets Groups Projects

Fix bug where apps are mapped to the wrong .desktop file and icon

Merged nyanpasu64 requested to merge nyanpasu64/xfce4-docklike-plugin:fix-wm-class into master

Fixes #18 (closed). Now VS Code, Sublime Text, and Wine apps with .desktop files and StartupWMClass set are mapped properly, show the right icon, can be pinned, etc.

Unresolved cases

Wine apps without an associated .desktop file are still broken. They show a generic app icon rather than the window's icon, cause docklike to print docklike-Message: 22:50:28.615: NO MATCH: winecfg.exe, and do not group. The app icon could be fixed by reading from _NET_WM_ICON, but I'm unsure how to fix grouping (maybe construct a synthetic category based on matching WM_CLASS without an associated .desktop file?). In any case it's an invasive change.

This MR causes less apps to resort to g_desktop_app_info_search, but does not fix the nondeterministic result for apps which still rely on it to find a .desktop file. (I don't know which apps rely on g_desktop_app_info_search and have multiple matches, though.)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading