Skip to content

Remove useless (?) desktop file

I can't send a PR, gitlab does not allow me to fork a project, so copy-pasting part of git format-patch -1 bellow. This is a suggestion. Full patch is attached. 0001-Remove-useless-desktop-file.patch

I do not see sense in the first desktop file on screenshot bellow on XFCE. Maybe it makes sense which I do not understand, maybe launching clipman manually may make sense, but the the desktop file must be called as sth about autostart.

2021-03-27_21-28

From 69eb140bdb20f9e6e6b147da2cc6d8dc9da43617 Mon Sep 17 00:00:00 2001
From: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>
Date: Sat, 27 Mar 2021 21:31:19 +0300
Subject: [PATCH] Remove useless desktop file

There is a duplication of desktop files:
$ rpm -ql xfce4-clipman-plugin | grep desktop
/etc/xdg/autostart/xfce4-clipman-plugin-autostart.desktop
/usr/share/applications/xfce4-clipman.desktop
<...>

xfce4-clipman-plugin-autostart.desktop starts Clipman, but xfce4-clipman.desktop does nothing,
at least in XFCE if Clipman is added to the panel...

Maybe it us useful for e.g. Cinnamon to start Clipman manually?

Regenerated po/ without changes to drop translations of the removed file.
---
 panel-plugin/Makefile.am              |   2 +-
 panel-plugin/xfce4-clipman.desktop.in |  12 -
 po/POTFILES.in                        |   1 -
 <...>

diff --git a/panel-plugin/Makefile.am b/panel-plugin/Makefile.am
index f513750..b166094 100644
--- a/panel-plugin/Makefile.am
+++ b/panel-plugin/Makefile.am
@@ -227,7 +227,7 @@ plugins_DATA = $(plugins_in_files:.desktop.in=.desktop)
 @INTLTOOL_DESKTOP_RULE@
 
 appsdir = $(datadir)/applications
-apps_in_files = xfce4-clipman.desktop.in xfce4-clipman-settings.desktop.in
+apps_in_files = xfce4-clipman-settings.desktop.in
 apps_DATA = $(apps_in_files:.desktop.in=.desktop)
 @INTLTOOL_DESKTOP_RULE@
 
diff --git a/panel-plugin/xfce4-clipman.desktop.in b/panel-plugin/xfce4-clipman.desktop.in
deleted file mode 100644
index bf6ceed..0000000
--- a/panel-plugin/xfce4-clipman.desktop.in
+++ /dev/null
@@ -1,12 +0,0 @@
-[Desktop Entry]
-Version=1.0
-Type=Application
-_Name=Clipboard Manager
-_Comment=Clipboard Manager Autostart File
-TryExec=xfce4-clipman
-Exec=xfce4-clipman
-Icon=xfce4-clipman-plugin
-Terminal=false
-Categories=GTK;Utility;TrayIcon;
-OnlyShowIn=XFCE;GNOME;X-Cinnamon;
-StartupNotify=false
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 0feb44f..4645db2 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,5 +1,4 @@
 data/appdata/xfce4-clipman.appdata.xml.in
-panel-plugin/xfce4-clipman.desktop.in
 panel-plugin/xfce4-clipman-actions.xml.in
 panel-plugin/xfce4-clipman-plugin.desktop.in
 panel-plugin/xfce4-clipman-plugin-autostart.desktop.in