correctmost authored 1 year ago and Alexander Schwinn committed 1 year ago

in method "thunar_io_jobs_util_next_duplicate_file"

MR xfce/thunar!433

instead of using a foreign, error-prone dialog, which does assumptions on the error-message formatting.

The ShortcutModel is reused by all ShortcutViews. So we need to disconnect from it manually when the view is finalized.

Regression introduced in 5e729d5f

If tree-view is used

When scanning non-readable directories

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

974 translated messages, 41 untranslated messages.

Transifex (https://explore.transifex.com/xfce/).

- Dont remove list elements whileiterating on the list
- Dont save bookmarks file for each removed list-element
- Only drop bookmark shortcuts, not all of them
- Only reload bookmark shortcuts, not all of them

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

The crash did not show before due to leakage of ThunarFile objects. Only after the recent leakage cleanings on themaster branch, it became an issue.

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

Caused by some timeout source ID which was not properly cleaned after usage

- Intoduced by a6573efe
- No need to listen to "changed" signal of folder
- Simplified method (do one thing)

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

if the creation of a ThunarFile fails for some reason. (Followup of !429)

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1014 translated messages, 1 untranslated message.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1013 translated messages, 2 untranslated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1015 translated messages.

Transifex (https://explore.transifex.com/xfce/).

Make use of the new "thunar_window_create_view" inside "thunar_window_set_current_directory" and simplify the method

Reuse code to switch to a different tab/view instead of duplicating it

Prevent duplicated code for history management of a new view

Use a separate method to create a new view. This is a prerequirement for further refactoring/simplification.

Abhijeetsingh Meena authored 1 year ago and Alexander Schwinn committed 1 year ago

For file paths and links in the properties' dialog, a tooltip now shows the complete path (Required, since long paths might be truncated in the dialog)

MR xfce/thunar!430

1014 translated messages.

Transifex (https://explore.transifex.com/xfce/).

1014 translated messages.

Transifex (https://explore.transifex.com/xfce/).