Latest from Master fails to build with the following errors

[   88s] Build Configuration:
[   88s] 
[   88s] * Maintainer Mode:        yes
[   88s] 
[   88s]     * Vala:               /usr/bin/valac 0.48.7
[   88s] 
[   88s] * Debug Support:          minimum
[   88s] 
[   89s] + /usr/bin/make -O -j8 V=1 VERBOSE=1
[   89s] /usr/bin/make  all-recursive
[   89s] Making all in src
[   90s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/xfmpc-0.3.0+git27.76b84db/src'
[   90s] rm -f xfmpc_vala.stamp && echo stamp > xfmpc_vala.stamp-t
[   90s] CDPATH="${ZSH_VERSION+.}:" && cd . && /usr/bin/valac --header=xfmpc.h --vapidir=. --vapidir=../third-party --pkg=libxfce4ui-2 --pkg=config --pkg=mpdclient --pkg=xfce-arrow-button  -C shortcuts-dialog.vala preferences-dialog.vala song-dialog.vala statusbar.vala dbbrowser.vala extended-interface.vala interface.vala main-window.vala playlist.vala preferences.vala progress-bar.vala main.vala
[   90s] shortcuts-dialog.vala:31.4-31.13: error: `Xfce.TitledDialog.add_button' is not available in libxfce4ui-2 4.15.3git-UNKNOWN. Use libxfce4ui-2 >= 4.16
[   90s] 			add_button (_("Close"), Gtk.ResponseType.CLOSE);
[   90s] 			^^^^^^^^^^
[   90s] preferences-dialog.vala:229.4-229.13: error: `Xfce.TitledDialog.add_button' is not available in libxfce4ui-2 4.15.3git-UNKNOWN. Use libxfce4ui-2 >= 4.16
[   90s] 			add_button (_("Close"), Gtk.ResponseType.CLOSE);
[   90s] 			^^^^^^^^^^
[   90s] song-dialog.vala:102.4-102.13: error: `Xfce.TitledDialog.add_button' is not available in libxfce4ui-2 4.15.3git-UNKNOWN. Use libxfce4ui-2 >= 4.16
[   90s] 			add_button (_("Close"), Gtk.ResponseType.CLOSE);
[   90s] 			^^^^^^^^^^
[   90s] extended-interface.vala:222.24-222.42: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			((Gtk.ToggleButton) this.context_button).set_active (false);
[   90s] 			                    ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:132.41-132.59: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 				this.context_menu_new ((Gtk.Widget) this.context_button);
[   90s] 				                                    ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:139.52-139.70: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			this.context_menu.popup_at_widget ((Gtk.Widget) this.context_button,
[   90s] 			                                                ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:215.29-215.47: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			if (!((Gtk.ToggleButton) this.context_button).get_active ())
[   90s] 			                         ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:76.4-76.22: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			this.context_button = new Xfce.ArrowButton (Gtk.ArrowType.DOWN);
[   90s] 			^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:77.14-77.32: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			((Widget) this.context_button).set_tooltip_text (_("Context Menu"));
[   90s] 			          ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:78.14-78.32: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			((Button) this.context_button).pressed.connect (popup_context_menu);
[   90s] 			          ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:78.4-78.41: warning: `Gtk.Button.pressed' has been deprecated since 2.8. Use Gtk.Widget.button_press_event
[   90s] extended-interface.vala:79.14-79.32: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			((Button) this.context_button).clicked.connect (cb_context_menu_clicked);
[   90s] 			          ^^^^^^^^^^^^^^^^^^^
[   90s] extended-interface.vala:80.31-80.49: warning: Access to static member `Xfmpc.ExtendedInterface.context_button' with an instance reference
[   90s] 			hbox.pack_start (((Widget) this.context_button), false, false, 0);
[   90s] 			                           ^^^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:266.4-266.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.set_text ("");
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:120.4-120.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry = new Entry ();
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:121.4-121.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.set_icon_from_icon_name (EntryIconPosition.PRIMARY, "edit-find");
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:122.4-122.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.set_icon_activatable (EntryIconPosition.PRIMARY, false);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:123.4-123.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.set_icon_activatable (EntryIconPosition.SECONDARY, true);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:127.16-127.32: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			pack_start (this.filter_entry, false, false, 0);
[   90s] 			            ^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:139.4-139.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.activate.connect (cb_filter_entry_activated);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:140.4-140.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.key_release_event.connect (cb_filter_entry_key_released);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:141.4-141.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.changed.connect (cb_filter_entry_changed);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] playlist.vala:142.4-142.20: warning: Access to static member `Xfmpc.Playlist.filter_entry' with an instance reference
[   90s] 			this.filter_entry.icon_release.connect (cb_filter_entry_icon_activated);
[   90s] 			^^^^^^^^^^^^^^^^^
[   90s] dbbrowser.vala:181.4-183.29: warning: unhandled error `GLib.Error'
[   90s] main-window.vala:26.3-26.36: warning: `Gtk.StatusIcon' has been deprecated since 3.14
[   90s] main-window.vala:36.3-36.38: warning: `Gtk.ActionGroup' has been deprecated since 3.10
[   90s] main-window.vala:37.3-37.34: warning: `Gtk.UIManager' has been deprecated since 3.10
[   90s] main-window.vala:270.34-270.50: warning: `Gtk.Action' has been deprecated since 3.10. Use GLib.Action
[   90s] main-window.vala:142.4-145.7: warning: unhandled error `GLib.Error'
[   90s] main-window.vala:174.4-174.30: warning: `Gtk.Menu.popup' has been deprecated since 3.22
[   90s] main-window.vala:202.8-202.57: error: Condition must be boolean
[   90s] 			if ((bool) event.changed_mask & Gdk.WindowState.STICKY && this.visible) {
[   90s] 			    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[   90s] main-window.vala:204.9-204.73: error: Equality operation: `bool' and `Gdk.WindowState' are incompatible
[   90s] 				if (((bool) event.new_window_state & Gdk.WindowState.STICKY) == false)
[   90s] 				    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[   90s] main-window.vala:334.8-334.13: warning: `Gtk.Action' has been deprecated since 3.10. Use GLib.Action
[   90s] main-window.vala:72.27-72.40: warning: `Gtk.StatusIcon' has been deprecated since 3.14
[   90s] main-window.vala:109.26-109.38: warning: `Gtk.UIManager' has been deprecated since 3.10
[   90s] main-window.vala:112.28-112.42: warning: `Gtk.ActionGroup' has been deprecated since 3.10
[   90s] main-window.vala:113.35-113.53: warning: Access to static member `Xfmpc.MainWindow.action_entries' with an instance reference
[   90s] 			this.action_group.add_actions (this.action_entries, this);
[   90s] 			                               ^^^^^^^^^^^^^^^^^^^
[   90s] main-window.vala:114.42-114.67: warning: Access to static member `Xfmpc.MainWindow.toggle_action_entries' with an instance reference
[   90s] 			this.action_group.add_toggle_actions (this.toggle_action_entries, this);
[   90s] 			                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[   90s] main-window.vala:117.41-117.54: warning: Access to static member `Xfmpc.MainWindow.ui_string' with an instance reference
[   90s] 				this.ui_manager.add_ui_from_string (this.ui_string, -1);
[   90s] 				                                    ^^^^^^^^^^^^^^

At least part of this is addressed in merge request !2 (merged)

mentioned in issue #7 (closed)

Looks like the other one is an issue in libxfce4ui and will start to work magically with the release of 4.16... This diff makes it work:

diff --git a/libxfce4ui/xfce-titled-dialog.c b/libxfce4ui/xfce-titled-dialog.c
index 52181a2..e96ef15 100644
--- a/libxfce4ui/xfce-titled-dialog.c
+++ b/libxfce4ui/xfce-titled-dialog.c
@@ -577,7 +577,7 @@ xfce_titled_dialog_create_action_area (XfceTitledDialog *titled_dialog)
  *
  * Return value: (transfer none): the GtkButton widget that was added.
  *
- * Since: 4.16
+ * Since: 4.15.2
  *
  **/
 GtkWidget *

This is just a comment in the c file, but is added as version information in /usr/share/vala/vapi/libxfce4ui-2.vapi.

So this was caused by: xfce/libxfce4ui@707cf22d

Any comment, @ochosi?

This is the first release where we enabled GObject Introspection overall, so this downside wasn't noticed in previous releases. It will be "magically fixed" as you mention with 4.16 final.

For the 4.18 cycle we will (have to?) migrate to development point releases in the docs, although I'm not a huge fan of this. Alternatively we have to include CI builds for not only "latest releases" but also for "latest stable releases".

We can add --disable-since-check on xfmpc_VALAFLAGS in src/Makefile.am to workaround the problem.

Maybe !4 (merged) for now?

Or alternatively let's focus on pushing out 4.16 in December - problem solved ;)

That code was written for GtkDialog not XfceTitledDialog, so it doesn't hurt to tell Vala which parent function should be called.

mentioned in merge request !4 (merged)

closed with commit 79f35336

assigned to @andreldm

changed milestone to %0.3.1