Skip to content

build: Bump GLib minimum required to 2.70

Gaël Bonithon requested to merge Tamaranch/xfdashboard:bump-glib into master

This is required by g_pattern_spec_match_string(), and xfce4-dev-tools >= 4.17.1 set GLIB_VERSION_MAX_ALLOWED to the GLib version found in configure.ac.in. This usually only generates deprecation warnings, but in some cases it changes the code path used at compile time and can cause memory corruption and crash.

Related: xfburn#54 (closed)

This is the simplest fix, but you may find that requiring GLib >= 2.70 is a bit high @nomad. In that case tell me if you prefer ifdefs, or feel free to close this MR if you prefer to do it yourself.

FYI, there are also other functions that require GLIb >= 2.68 (g_memdup2()), 2.62 (g_array_copy()), and lower. You can get the warnings by building with xfce4-dev-tools >= 4.17.1, or add that to configure.ac.in:

AC_DEFINE(GLIB_VERSION_MAX_ALLOWED, GLIB_VERSION_2_38, Warn when using post 2_38 APIs)
AC_DEFINE(GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_2_38, Don't warn about post 2_38 deprecations)

Merge request reports