How can I scale up the icons in the quicklaunch window?

Submitted by Rp

Assigned to Stephan Haller @nomad

Link to original bug (#16443)

Description

Created attachment 9438 My current theme

Hi there,

How can I scale up the icons in the quicklaunch window?

I've just started my own theme to get something I would like, and then I'm reading this documentation:

http://xfdashboard.froevel.de/theming.html

And, as of now, the quicklaunch icons are unfortunately very small (please see enclosed screenshot).

Thanks a lot for your help!

Best, Rp

Attachment 9438, "My current theme":

Stephan Haller @nomad said:

Hi,

glad to hear you are trying to create your own theme but it's not easy to tell as I don't know your theme. I don't know how much space was assigned to the quicklaunch box and how your CSS looks like.

Please check your properties for the XfdashboardQuicklaunch widget in the layout file (usually xfdashboard.xml) and your CSS file according to http://xfdashboard.froevel.de/theming.html#theme-stylable-properties-XfdashboardQuicklaunch

The property "normal-icon-size" manages the unscaled size of the icons in the quicklaunch box. The default value is 1px (pixel) and if I look at the attached image I think you have already set this properties to a higher value. Please keep in mind that this properties defines the unscaled size of the icons. The icons will be scaled down if they do not fit into the quicklaunch box anymore. That means the more icons you have in the quicklaunch the more likely they do not fit into the qucklaunch's box space and they need to be scaled down to fit again.

Regards Stephan

Rp uploaded an attachment:

Attachment 9468, "Layout configuration file":
xfdashboard.xml

Rp said:

Hi Stephan,

Thanks a lot for your help.

Yes, I forgot to enclose the configuration file - my fault - sorry about that. Please find it enclosed.

Basically, I removed everything except the quick-launch bar to have it screen wide. And I would like large icons to click on.

Here is the quicklaunch section of the layout file:

				`<object class="XfdashboardQuicklaunch" id="quicklaunch">`
					`<property name="can-focus">`true`</property>`
					`<property name="orientation">`horizontal`</property>`
					`<property name="x-expand">`true`</property>`
					`<property name="y-expand">`true`</property>`
					`<property name="homogeneous">`true`</property>`
					`<property name="normal-icon-size">`128`</property>`
				`</object>`

--

So I tried the 'normal-icon-size' property, but nothing changed.

And as the screenshot shows, I still have a lot of space above, on the right, and below.

So I am not sure what I am doing wrong.

Thanks a lot for your work!

Best regards, Rp

Stephan Haller @nomad uploaded an attachment:

Attachment 9469, "Your layout file overriding the layout file of xfdahboard-blue":

Stephan Haller @nomad said:

Hi,

I copied the theme "xfdashboard-blue" and replaced the layout file "xfdashboard.xml" with your version and ... what should I say? It looks like expected. Very big icons which fit into screen as you can see at my attached screenshot.

If the space filled by the quicklaunch is okay but "only" the icon size is incorrect, have you checked your CSS file if it overrides the property "normal-icon-size" of your quicklaunch? CSS files have higher priority as the layout file.

Regards, Stephan

Rp uploaded an attachment:

Attachment 9471, "Full theme":
xfdashboard-myblue.tar.gz

Rp uploaded an attachment:

Attachment 9472, "Screenshot: icons got smaller":

Rp said:

Hi Stephan,

Thank you for your help.

Ok, I did miss the line

@import(xfdashboard.css)

in the CSS file.

So I edited it to remove all references to icon-size.

Unfortunately, the icons even got smaller (screenshot enclosed). I am doing something wrong, but I do not know what. So I attached the full theme.

Thanks a lot for your help.

Best regards, Rp

Stephan Haller @nomad said:

Hi,

short question: Which version of xfdashboard do you use?

Regards, Stephan

Rp said:

The one provided by the package system: 0.6.1

If we can't make it work, it's alright. It's just that I find dashboards more convenient than menus.

Thanks a lot!

changed milestone to %0.8

added Bug Question Theme labels

added To Do label

removed To Do label

added To Do label

Incorrect icon scaling only occurs with horizontal orientation, can be fixed by executing this only if vertical orientation is set. Just a quick fix, not sure if it is correct.

Fixed:

@michal4132 Thanks for the hint. Yes, this function should only be called if the orientation of quicklaunch is vertical and so it needs a different function for horizontal orientation which already exist.

As it seems that you know this problem (and solved it with a quick fix) and also have a theme for this problem, may I ask you if the following patch would work?

--- libxfdashboard/quicklaunch.c.old	2022-06-16 08:41:48.254186785 +0200
+++ libxfdashboard/quicklaunch.c	2022-06-16 08:42:40.501325486 +0200
@@ -2546,7 +2546,14 @@
 	clutter_actor_box_get_size(inBox, &availableWidth, &availableHeight);
 
 	/* Find scaling to get all children fit the allocation */
-	priv->scaleCurrent=_xfdashboard_quicklaunch_get_scale_for_height(self, availableHeight, FALSE);
+	if(priv->orientation==CLUTTER_ORIENTATION_HORIZONTAL)
+	{
+		priv->scaleCurrent=_xfdashboard_quicklaunch_get_scale_for_width(self, availableWidth, FALSE);
+	}
+		else
+		{
+			priv->scaleCurrent=_xfdashboard_quicklaunch_get_scale_for_height(self, availableHeight, FALSE);
+		}
 
 	/* Calculate new position and size of visible children */
 	childAllocation.x1=childAllocation.y1=priv->spacing;

Regards, Stephan

changed milestone to %1.0

I can confirm that this patch works as expected.

Thanks

closed with commit b86ed5e4